Release 3.4.2 preparation #630
Conversation
conda-bot
added
the
cla-signed
| @@ -94,7 +94,7 @@ def modify_xml(xml_path, info): | |||
| background_path = join(OSX_DIR, 'MacInstaller.png') | |||
|
|
|||
| if background_path: | |||
| logger.info("Using background image", background_path) | |||
| logger.info("Using background image: %s", background_path) | |||
There was a problem hiding this comment.
Is this not caught by any linter? I'm surprised 🤔
There was a problem hiding this comment.
yeah, me too. Seems like I previously only inspected the linux/windows logs and flake8 seems to not catch it (I am more used to pylint, which seems too be able to catch it... pylint is generally stricter, but also supports different code styles and options so that is hard to find an agreement what to set... flake8 is like the baseline linter, not so strict, default options are sane, extendable via extension)
After I found this one occurence, I inspected the full logs via printing stdout/stderr also in succeeding tests in my fork of the repo (where the CI was not clogged). Those logs are awesome now: you see how constructor runs start in main, continue in e.g. osxpkg, utils, fcp, back to osxpkg until it finishes etc ...
Description
closes #629
Be carefully reviewing this, it contains more than just changelog updates: During preparing the release I looked through our Github CI runs once again, inspected all the CI logs, downloaded the created installers and inspected them. I found one logging error + a documentation error. Both are fixed by this PR including Changelog update! See the last commits in this PR. I can split this out into a separate PR, but that is no fun, given the current clogged GitHub Action runners.
Checklist - did you ...
newsdirectory (using the template) for the next release's release notes?