Cache header.sh and use loops to speedup unit tests #625
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
conda-bot
added
the
cla-signed
dbast
force-pushed
the
faster_unittests
branch
2 times, most recently
from
934ff10
to
01dfd17
Compare
dbast
force-pushed
the
faster_unittests
branch
from
01dfd17
to
079bad9
Compare
jaimergp
reviewed
Jan 24, 2023
jaimergp
reviewed
Jan 24, 2023
|
Out of an abundance of caution, does this fail if we intentionally mess one of the |
|
@jaimergp yes, tested that. |
jaimergp
approved these changes
Jan 24, 2023
|
Ignoring unrelated test failure. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The test case
test_linux_template_processingwas producing ~20k test cases by being parametrised via lots of parameters and@pytest.mark.parametrize. A lot of execution time was spent by pytest for orchestrating that many tests. By turning the parameters into a loop, the test cases could be reduced to 67 and the overall execution time from ~4:30 to 47 sec (macOS), ~2:15 to 22 sec (linux), 4:30 to 38 sec (windows).Checklist - did you ...
newsdirectory (using the template) for the next release's release notes?