Hardcode paths to Apple's system tools #543
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
conda-bot
added
the
cla-signed
isuruf
previously approved these changes
Aug 12, 2022
goanpeca
reviewed
Aug 12, 2022
goanpeca
reviewed
Aug 12, 2022
goanpeca
reviewed
Aug 12, 2022
goanpeca
previously approved these changes
Aug 12, 2022
|
Maybe we can use a variable for the PREFIX. APPLE_TOOLS_PREFIX + "/codesign"or something 🤷🏼 |
hoechenberger
previously approved these changes
Aug 12, 2022
jaimergp
dismissed stale reviews from hoechenberger, goanpeca, and isuruf
via
7b718d0
hoechenberger
approved these changes
Aug 15, 2022
|
Thanks @hoechenberger - this automated review dismissal is a bit inconvenient :( |
|
Yep, can this be disabled? We could also set up automerge for when reviews are in and CI passes. WDYT? |
|
Agree, that'd be nice. I think we need to ask someone with more permissions though. Let's create an issue. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We ran into this issue in the napari/packaging#11. Apparently some package in the dependency tree includes a
codesignbinary too, with a different CLI. This can get in the way of our signing process, resulting in a 109 error.This happened because we let
subprocesspick the firstcodesignin PATH. The fix is to hardcode the location to/usr/bin/codesign, ascondaitself does.I also applied the same patch to
productbuildandproductsign, just in case.Checklist - did you ...
newsdirectory (using the template) for the next release's release notes?