Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

On macOS, display the installer version in the window title #536

Merged
merged 3 commits into from
Jul 28, 2022
Merged

On macOS, display the installer version in the window title #536

merged 3 commits into from
Jul 28, 2022

Conversation

hoechenberger
Copy link
Contributor

No description provided.

@conda-bot
Copy link
Contributor

We require contributors to sign our Contributor License Agreement and we don't have one on file for @hoechenberger.

In order for us to review and merge your code, please e-sign the Contributor License Agreement PDF. We then need to manually verify your signature. We will ping the bot to refresh the PR status when we have confirmed your signature.

@kenodegard
Copy link
Contributor

@conda-bot check

@conda-bot conda-bot added the cla-signed [bot] added once the contributor has signed the CLA label Jul 27, 2022
CHANGELOG.rst Outdated Show resolved Hide resolved
@larsoner
Copy link

The bot and CI say "CLA check — CLA signed, thank you!", so this is okay to merge at this point, right @kenodegard ? I can just do it in the future if that's the case, but want to double check this first time. I haven't worked with CLAs much...

@kenodegard
Copy link
Contributor

kenodegard commented Jul 28, 2022

@larsoner Yes, you are free to finish reviewing/merging.

FYI, the process in place is we (currently the conda team at Anaconda) get the signed CLA form, we add the user's GitHub login to https://github.com/conda/infra/blob/main/.clabot, and then retrigger the CLA check (by reopening the PR, adding more commits, or commenting @conda-bot check).

@larsoner
Copy link

FYI, the process in place is

Nice, thanks for the info!

This seems like a pretty straightforward enhancement, we can always add an option to disable it if people want in the future (but I'm assuming YAGNI for now), thanks @hoechenberger !

@larsoner larsoner merged commit 86ceb4b into conda:main Jul 28, 2022
@github-actions github-actions bot added the locked [bot] locked due to inactivity label Jul 28, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla-signed [bot] added once the contributor has signed the CLA locked [bot] locked due to inactivity
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants