Fix constructor failures when the repo/subchannel only has noarch packages #512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We require contributors to sign our Contributor License Agreement, and we don't have one on file for @bryan-hunt. In order for us to review and merge your code, please e-sign the PDF at https://conda.io/en/latest/contributing.html#conda-contributor-license-agreement. We then need to manually verify your signature. We will ping the bot to refresh the PR status when we have confirmed your signature. |
|
CLA has been signed |
conda-bot
added
the
cla-signed
|
Just ran into this issue too, applied your patch and it worked! I am re-running the CI to make sure everything is alright. Merging later if green! |
* Setting full_repodata to None causes write_repodata to throw an AttributeError exception * Initializing to empty repodata minimizes the changes required throughout constructor.
3 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the full_repodata is set to None it causes write_repodata to throw an AttributeError exception because it immediately tries to treat it as an initialized dictionary.
Instead of returning none this change returns an initialized repodata dictionary with the minimum expected data which allows constructor to continue properly.