Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for additional files #500

Merged
merged 13 commits into from
Jul 28, 2022
Merged

add support for additional files #500

merged 13 commits into from
Jul 28, 2022

Conversation

jaimergp
Copy link
Contributor

@jaimergp jaimergp commented Mar 11, 2022

This PR adds a new key, extra_files. From the help message:

Extra, non-packaged files that should be added to the installer. If provided as relative
paths, they will be considered relative to the directory where construct.yaml is.
This setting can be passed as a list of:

  • str: each found file will be copied to the root prefix
  • Mapping[str, str]: map of path in disk to path in prefix.

A new example, extra_files has been included.

Closes #465

@anaconda-issue-bot anaconda-issue-bot added the cla-signed [bot] added once the contributor has signed the CLA label Mar 11, 2022
@hoechenberger
Copy link
Contributor

Great work! Any chance we could see this getting merged sometime soon?

Copy link

@larsoner larsoner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any chance to at least test the Linux case in tests/test_header.py ?

Seeing these PRs and functionality for each OS makes me think we could really use tests for more than just Linux for all these options

@jaimergp
Copy link
Contributor Author

@larsoner This PR includes an example YAML using these keys, which means the CI will build and run the installers. The only thing we are not testing is whether the installation contains those files.

@jaimergp
Copy link
Contributor Author

I finally figured out how to use post_install scripts to run some tests. The PR now includes tests for this feature, and also adds some for the branding PR (custom location stuff). I'll add more post-install tests in a new PR to make sure everything is tidy and clean!

@larsoner @hoechenberger can you take another look? Thanks!

@jaimergp jaimergp merged commit 8d310b5 into conda:main Jul 28, 2022
@github-actions github-actions bot added the locked [bot] locked due to inactivity label Jul 29, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla-signed [bot] added once the contributor has signed the CLA locked [bot] locked due to inactivity
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Include additional files in construct.yaml
4 participants