-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add support for additional files #500
Conversation
Great work! Any chance we could see this getting merged sometime soon? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any chance to at least test the Linux case in tests/test_header.py
?
Seeing these PRs and functionality for each OS makes me think we could really use tests for more than just Linux for all these options
@larsoner This PR includes an example YAML using these keys, which means the CI will build and run the installers. The only thing we are not testing is whether the installation contains those files. |
I finally figured out how to use post_install scripts to run some tests. The PR now includes tests for this feature, and also adds some for the branding PR (custom location stuff). I'll add more post-install tests in a new PR to make sure everything is tidy and clean! @larsoner @hoechenberger can you take another look? Thanks! |
This PR adds a new key,
extra_files
. From the help message:A new example,
extra_files
has been included.Closes #465