-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
run examples outside conda build to upload installers as artifacts for local testing #498
Conversation
Ready for review. This is how it looks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs some tweaks :)
|
||
|
||
if __name__ == '__main__': | ||
run_examples() | ||
if sys.argv[1].startswith('--keep-artifacts='): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should check that len(sys.argv) >=2
before accessing the element.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch!
Since a lot of changes are incoming, this should simplify testing things locally, especially those that require visual inspection.