Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

run examples outside conda build to upload installers as artifacts for local testing #498

Merged
merged 9 commits into from
Mar 11, 2022

Conversation

jaimergp
Copy link
Contributor

Since a lot of changes are incoming, this should simplify testing things locally, especially those that require visual inspection.

@anaconda-issue-bot anaconda-issue-bot added the cla-signed [bot] added once the contributor has signed the CLA label Mar 10, 2022
@jaimergp
Copy link
Contributor Author

Ready for review. This is how it looks!

image

@jaimergp jaimergp requested a review from jezdez March 10, 2022 13:31
Copy link
Member

@jezdez jezdez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs some tweaks :)

.github/workflows/main.yml Show resolved Hide resolved
.github/workflows/main.yml Outdated Show resolved Hide resolved
.github/workflows/main.yml Show resolved Hide resolved
scripts/run_examples.py Outdated Show resolved Hide resolved
scripts/run_examples.py Outdated Show resolved Hide resolved
scripts/run_examples.py Show resolved Hide resolved
@jezdez jezdez merged commit be41e36 into conda:master Mar 11, 2022


if __name__ == '__main__':
run_examples()
if sys.argv[1].startswith('--keep-artifacts='):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should check that len(sys.argv) >=2 before accessing the element.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@jaimergp jaimergp mentioned this pull request Mar 14, 2022
3 tasks
@github-actions github-actions bot added the locked [bot] locked due to inactivity label Mar 16, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla-signed [bot] added once the contributor has signed the CLA locked [bot] locked due to inactivity
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants