-
-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add recipe for ckzg #26068
base: main
Are you sure you want to change the base?
Add recipe for ckzg #26068
Conversation
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
Note that upstream has in the meantime added a patch for the Windows issue at ethereum/c-kzg-4844#419. You can turn that into a patch here, or skip Windows until a new release with the patch comes out. |
I saw this, because as you can see I was in that discussion with upstream, but there is no indication that that patch solves this particular windows issue. I had wanted to test it, but as I wrote had/have trouble getting a system able to test it. |
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( I do have some suggestions for making it better though... For recipes/ckzg:
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
@conda-forge/core please review/approve with the original build script or tell me how I can force/replace the build script to use only clang. The way @xhochy suggested did not work, thus I reverted the commits to a working build. |
what if you removed clang alltogether? |
I assume it would still clash with this Makefile https://github.com/ethereum/c-kzg-4844/blob/main/src/Makefile which has
Windows also probably does not really use this file, as in
I'm not saying these are great, but I assume I would have to patch them only use either clang or gcc. (and I do not know if there was a reason to only use either) |
you'll have to patch
|
This unfortunately fails on Win, which still uses cl.exe. Any ideas? (I also patched out the use of the windows bat file, as it didn't use either gcc or clang and I'm not sure what kind of magic it is doing. |
Maybe disable Windows and then we can review/merge? The Windows portion could be revisited in the feedstock |
Ok good idea. Windows build is skipped now. |
This is ready for review, @conda-forge/help-python |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Florian! 🙏
Added a couple minor suggestions below
Co-authored-by: jakirkham <jakirkham@gmail.com>
Co-authored-by: jakirkham <jakirkham@gmail.com>
Co-authored-by: jakirkham <jakirkham@gmail.com>
Hey, @jakirkham without any patch, we are now again at the juncture of this Makefile I referred to here: #26068 (comment) |
@step21 After a few days looking into it, I proposed this: #27412, which should build Windows using gcc 5, separate |
Awesome, thanks for your work. Looks great from what I can tell. I don't know yet if I can take a look at the remaining build failures. |
Cool. I am still working on it. I want to enforce linking to the versioned dynamic library and it's a bit trickier. It feels more reliable, but maybe overkill. As for windows, it's my Achilles heel, I had it working but must have changed something during the many refactoring. I'll ping you when I get it to pass |
Similar functionality with separated |
Checklist
url
) rather than a repo (e.g.git_url
) is used in your recipe (see here for more details).