add smina

[jaimergp]

Checklist

• Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml"
• License file is packaged (see here for an example)
• Source is from official source
• Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged)
• If static libraries are linked in, the license of the static library is packaged.
• Build number is 0
• A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details)
• GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there
• When in trouble, please check our knowledge base documentation before pinging a team.

[conda-forge-linter]

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/smina) and found some lint.

Here's what I've got...

For recipes/smina:

• Selectors are suggested to take a <two spaces>#<one space>[<expression>] form. See lines [13]

For recipes/smina:

• Recipe with the same name exists in bioconda: please discuss with @conda-forge/bioconda-recipes.

[conda-forge-linter]

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/smina) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipes/smina:

• Recipe with the same name exists in bioconda: please discuss with @conda-forge/bioconda-recipes.

[jaimergp]

@conda-forge/bioconda-recipes:

I am bringing this recipe here for the following reasons:

• Package at bioconda repackages the sourceforge binaries, so there's no provenance
• It's from 2017
• I want to use the tooling at conda-forge for multiarch builds
• I am planning on adding more packages that will depend on smina

Thanks!

[conda-forge-linter]

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/smina) and found some lint.

Here's what I've got...

For recipes/smina:

• When defining a source/url please add a sha256, sha1 or md5 checksum (sha256 preferably).
• When defining a source/url please add a sha256, sha1 or md5 checksum (sha256 preferably).

For recipes/smina:

• Recipe with the same name exists in bioconda: please discuss with @conda-forge/bioconda-recipes.

[conda-forge-linter]

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/smina) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipes/smina:

• Recipe with the same name exists in bioconda: please discuss with @conda-forge/bioconda-recipes.

[conda-forge-linter]

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/smina) and found some lint.

Here's what I've got...

For recipes/smina:

• When defining a source/url please add a sha256, sha1 or md5 checksum (sha256 preferably).

For recipes/smina:

• Recipe with the same name exists in bioconda: please discuss with @conda-forge/bioconda-recipes.

[conda-forge-linter]

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/smina) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipes/smina:

• Recipe with the same name exists in bioconda: please discuss with @conda-forge/bioconda-recipes.

[jaimergp]

@conda-forge/bioconda-recipes, @conda-forge/help-c-cpp, this is ready for review. See previous comment for the rationale of this submission.

Some details:

• Official source exists at Sourceforge, which is git based, but doesn't offer a permalink for tarballs. Cloning the repo doesn't work on Windows for some reason. So I mirrored it to my GitHub profile and tagged it accordingly.
• The CMake config needed some tweaks to support Windows.
• I overrode the version.cpp autogeneration so it uses metadata from the recipe, instead of the (non-existing) git data.

[simonbray]

Moving this from bioconda seems like a good idea to me. 👍 Don't know if you have any other view @bgruening?

Official source exists at Sourceforge, which is git based, but doesn't offer a permalink for tarballs.

It seems sourceforge does allows download of a 'snapshot'. For example, the latest revision can be accessed as a ZIP file via https://sourceforge.net/code-snapshots/git/s/sm/smina/code.git/smina-code-cbf423575b585a296171e3ee916d2d0f0d5dfb0a.zip.

[jaimergp]

It seems sourceforge does allows download of a 'snapshot'.

They do, but it "expires" 🤯 See this log. You have to ask first in the /tarball endpoint, which is a dynamic piece of HTML that cannot be checksum'd. I tried the most creative workarounds (low-key proud of this one), but I concluded it created more problems than solved. So I decided to just mirror as needed. It's not that the repo has a huge traffic anyway.

[simonbray]

Ah ok, it seems you already investigated this quite thoroughly. 😆 Then I agree that the GitHub mirror is the best solution.

[chrisburr]

Looks good 👍

Is there anything that needs to be done by @conda-forge/bioconda-recipes before it's merged?

[simonbray]

Is there anything that needs to be done by @conda-forge/bioconda-recipes before it's merged?

I created a PR to remove smina from the bioconda-recipes repo here: bioconda/bioconda-recipes#26483. However, it's fine for this PR to be merged already.

[jaimergp]

Thanks @chrisburr and @simonbray!