Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update subpackage pin versions for generic packages #142

Merged
merged 6 commits into from
May 7, 2023
Merged

Update subpackage pin versions for generic packages #142

merged 6 commits into from
May 7, 2023

Conversation

sshockwave
Copy link
Member

@sshockwave sshockwave commented May 5, 2023

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

Fixes: #124 (comment)

pin_subpackage defaults to min_pin='x.x.x.x.x.x and max_pin='x'. exact=True also includes the build string, which limits the platform of the dependencies to the one used to build the generic package. Both are unintended.

@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@sshockwave
Copy link
Member Author

@conda-forge-admin please rerender

@github-actions
Copy link
Contributor

github-actions bot commented May 5, 2023

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like there was nothing to do.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/rust-feedstock/actions/runs/4888678740.

@isuruf isuruf added the automerge Merge the PR when CI passes label May 5, 2023
@github-actions
Copy link
Contributor

github-actions bot commented May 5, 2023

Hi! This is the friendly conda-forge automerge bot!

I considered the following status checks when analyzing this PR:

  • linter: passed
  • azure: failed

Thus the PR was not passing and not merged.

@sshockwave
Copy link
Member Author

@conda-forge-admin please restart ci

@pkgw
Copy link
Contributor

pkgw commented May 5, 2023

The Cargo build tests on the Linux cross-arch platforms are getting killed:

+ cargo install --force xsv
    Updating crates.io index
/home/conda/feedstock_root/build_artifacts/rust-split_1683256056938/test_tmp/run_test.sh: line 10:  3283 Killed                  cargo install --force xsv

I don't think that this is simply due to a timeout or anything, but I don't see any hints about why this is happening ☹️

@isuruf
Copy link
Member

isuruf commented May 5, 2023

If it takes too much memory, then the process might get killed.

@pkgw
Copy link
Contributor

pkgw commented May 5, 2023

Has anything changed about the Azure infrastructure recently? This PR shouldn't affect anything like that, I'd hope. (One could do a test and see what happens if the main branch is rebuilt as-is.)

(edit: or maybe the Crates.io index just passed some size threshold that leads to problems on these platforms, perhaps??)

@github-actions github-actions bot removed the automerge Merge the PR when CI passes label May 7, 2023
@github-actions
Copy link
Contributor

github-actions bot commented May 7, 2023

Hi! This is the friendly conda-forge automerge bot!

Commits were made to this PR after the automerge label was added. For security reasons, I have disabled automerge by removing the automerge label. Please add the automerge label again (or ask a maintainer to do so) if you'd like to enable automerge again!

@sshockwave
Copy link
Member Author

sshockwave commented May 7, 2023

(edit: or maybe the Crates.io index just passed some size threshold that leads to problems on these platforms, perhaps??)

@pkgw I agree. These two platforms seem to be using QEMU containers for emulation. Similar OOM issues are reported in rust-lang/cargo#10583 (comment) where replacing libgit2 with git cli is a workaround.

However, I believe that HTTP-based sparse-registry rust-lang/cargo#11224 (comment) is the future-proof way for CIs. Should be available since rust 0.68.0.

@isuruf
Copy link
Member

isuruf commented May 7, 2023

Thanks

@isuruf isuruf merged commit cfdf169 into conda-forge:main May 7, 2023
@sshockwave sshockwave deleted the patch-1 branch May 7, 2023 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

install rust-src from conda?
3 participants