Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bot-automerge] Rebuild for r-base 4.4 and UCRT mingw toolchain #44

Conversation

regro-cf-autotick-bot
Copy link
Contributor

This PR has been triggered in an effort to update r-base44_and_m2w64-ucrt.

Notes and instructions for merging this PR:

  1. Please merge the PR only after the tests have passed.
  2. Feel free to push to the bot's branch to update this PR if needed.

Please note that if you close this PR we presume that the feedstock has been rebuilt, so if you are going to perform the rebuild yourself don't close this PR until the your rebuild has been merged.


If this PR was opened in error or needs to be updated please add the bot-rerun label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase @conda-forge-admin, please rerun bot in a PR comment to have the conda-forge-admin add it for you.

This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by - please use this URL for debugging.

@regro-cf-autotick-bot regro-cf-autotick-bot requested a review from a team as a code owner June 30, 2024 12:34
@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

Copy link
Contributor

Hi! This is the friendly conda-forge automerge bot!

I considered the following status checks when analyzing this PR:

  • linter: passed
  • azure: failed

Thus the PR was not passing and not merged.

@mfansler
Copy link
Member

mfansler commented Jul 1, 2024

Reports missing libgfortran on win R 4.4.

@mbargull
Copy link
Member

mbargull commented Jul 1, 2024

Reports missing libgfortran on win R 4.4.

I've noticed that one in a few other feedstocks too and opened conda-forge/r-base-feedstock#325 to track common issues.

Copy link
Contributor

github-actions bot commented Jul 1, 2024

Hi! This is the friendly conda-forge automerge bot!

It appears that not all commits to this PR were made by the bot. Thus this PR is not being automatically merged. Please add the automerge label again (or ask a maintainer to do so) if you'd like to enable automerge again!

This reverts commit 6b9d476.

Signed-off-by: Marcel Bargull <marcel.bargull@udo.edu>
@mbargull
Copy link
Member

mbargull commented Jul 2, 2024

@conda-forge-admin, please restart ci

@mbargull
Copy link
Member

mbargull commented Jul 2, 2024

The new builds seem to be broken with

      0 [main] make (4996) fstab_read_flags: invalid fstab option - '
D:/bld/r-matrix_1719951128302/_build_env/Library/bin'

likely due to malformed fstab coming from the new m2-filesystem build after conda-forge/m2-binary-packages-feedstock#9 .
conda-forge/m2-binary-packages-feedstock#10 should fix the etc/fstab.

@mbargull
Copy link
Member

mbargull commented Jul 3, 2024

@isuruf, even with m2-filesystem:Library/etc/fstab modified as intended, the builds fail (even the 4.3 now).

diff -ru0 m2-filesystem-2023.02.07.1-hd8ed1ab_2/Library/etc/fstab m2-filesystem-2023.02.07.1-hd8ed1ab_4/Library/etc/fstab
--- m2-filesystem-2023.02.07.1-hd8ed1ab_2/Library/etc/fstab	2024-06-17 23:01:33.874019622 +0000
+++ m2-filesystem-2023.02.07.1-hd8ed1ab_4/Library/etc/fstab	2024-07-03 04:15:53.097105264 +0000
@@ -9,0 +10 @@
+D:/bld/m2-binary-packages_1719976129475/_h_env/Library/bin /conda_bin ntfs auto

They did, however, pass with the m2-*=*=*-2 packages, i.e., with the non-modified fstab (+bashrc patch).

recipe/bld.bat Outdated
@@ -1,2 +1,4 @@
set "R_CUSTOM_TOOLS_PATH=%BUILD_PREFIX:\=/%/Library/usr/bin2"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think R_CUSTOM_TOOLS_PATH is usable anymore for the current r-base builds due to

# diff -u r-base-4.4.1-hc390f20_{9,10}/lib/R/library/base/R/Rprofile
--- r-base-4.4.1-hc390f20_9/lib/R/library/base/R/Rprofile	2024-07-01 06:53:24.799186944 +0000
+++ r-base-4.4.1-hc390f20_10/lib/R/library/base/R/Rprofile	2024-07-02 04:33:31.126751661 +0000
@@ -194,7 +194,7 @@
 local({
     # keep in step with Rcmd_environ
     setRtools44Path <- 0
-     setRtools44Path <- 1
+    # INSTALLER-BUILD: setRtools44Path <- 1
 
     if (setRtools44Path) {
         aarch64 <- FALSE

@isuruf
Copy link
Member

isuruf commented Jul 4, 2024

With the fstab fix, it's using the compilers from BUILD_PREFIX instead of PREFIX which is the correct behaviour. conda-forge/r-base-feedstock#328 should fix this issue.

Copy link
Member

@mfansler mfansler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updates and build logs look clean to me!

Thanks both for all your work here! ❤️

@isuruf
Copy link
Member

isuruf commented Jul 10, 2024

Merge?

@dbast dbast merged commit 62ff386 into conda-forge:main Jul 12, 2024
14 checks passed
@regro-cf-autotick-bot regro-cf-autotick-bot deleted the rebuild-r-base44_and_m2w64-ucrt-0-1_h831b0c branch July 12, 2024 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants