Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to cross-compilation for linux_aarch64 and linux_ppc64le #8

Merged
merged 4 commits into from
Apr 16, 2024

Conversation

bdice
Copy link
Contributor

@bdice bdice commented Apr 10, 2024

This PR switches to cross-compilation for linux_aarch64 and linux_ppc64le.

See conda-forge/cuda-feedstock#25

@bdice bdice requested a review from a team as a code owner April 10, 2024 17:10
@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

Make sure `compute-sanitizer` can be found in the path.
When cross-compiling, we are not able to run `compute-sanitizer
--version` as we are not on the `target_platform`. So skip this test in
that case. The existence test should suffice for determine that the
executable is available and can be found.
@jakirkham
Copy link
Member

@conda-forge-admin , please re-render

Comment on lines +52 to +53
- {{ exists }} compute-sanitizer
- compute-sanitizer --version # [build_platform == target_platform]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As we cannot run compute-sanitizer when cross-compiling, have modified the test above to simply check the existence of the command on all platforms. So there is some test that the executable exists even when cross-compiling

Then limited running compute-sanitizer to native builds

@jakirkham jakirkham requested a review from adibbley April 16, 2024 19:31
Copy link
Contributor Author

@bdice bdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jakirkham I can’t approve my own PR but your changes look fine to me.

@jakirkham
Copy link
Member

Alex mentioned offline he is having Internet trouble today

Will go ahead and merge to get this in

That said, happy to follow up on anything after as needed

@jakirkham jakirkham merged commit e1e108a into conda-forge:main Apr 16, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants