-
-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to cross-compilation for linux_aarch64
and linux_ppc64le
#8
Conversation
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
Make sure `compute-sanitizer` can be found in the path.
When cross-compiling, we are not able to run `compute-sanitizer --version` as we are not on the `target_platform`. So skip this test in that case. The existence test should suffice for determine that the executable is available and can be found.
@conda-forge-admin , please re-render |
…nda-forge-pinning 2024.04.16.18.27.35
- {{ exists }} compute-sanitizer | ||
- compute-sanitizer --version # [build_platform == target_platform] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As we cannot run compute-sanitizer
when cross-compiling, have modified the test above to simply check the existence of the command on all platforms. So there is some test that the executable exists even when cross-compiling
Then limited running compute-sanitizer
to native builds
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jakirkham I can’t approve my own PR but your changes look fine to me.
Alex mentioned offline he is having Internet trouble today Will go ahead and merge to get this in That said, happy to follow up on anything after as needed |
This PR switches to cross-compilation for
linux_aarch64
andlinux_ppc64le
.See conda-forge/cuda-feedstock#25