Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch with Rpath rather than runpath, to give precedence to patched location over LD_LIBRARY_PATH #10

Merged
merged 7 commits into from
Jul 23, 2024

Conversation

danpetry
Copy link
Contributor

@danpetry danpetry commented May 9, 2024

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@danpetry danpetry requested a review from a team as a code owner May 9, 2024 21:53
@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe:

@danpetry
Copy link
Contributor Author

danpetry commented May 9, 2024

@conda-forge-admin, please rerender

Copy link
Contributor

github-actions bot commented May 9, 2024

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you but ran into some issues. Please check the output logs of the latest webservices GitHub actions workflow run for errors. You can also ping conda-forge/core for further assistance or you can try rerendeing locally.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/cuda-sanitizer-api-feedstock/actions/runs/9024028236.

@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@danpetry
Copy link
Contributor Author

@conda-forge-admin, please rerender

Copy link
Contributor

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like there was nothing to do.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/cuda-sanitizer-api-feedstock/actions/runs/9037148438.

@vyasr
Copy link

vyasr commented May 13, 2024

Thanks, looks like I missed one in conda-forge/cuda-cudart-feedstock#21!

@bdice
Copy link
Contributor

bdice commented May 13, 2024

I merged #9 first, and bumped the build number again. This is good to go when CI passes.

@bdice bdice added automerge Merge the PR when CI passes labels May 13, 2024
Copy link
Contributor

github-actions bot commented May 13, 2024

Hi! This is the friendly conda-forge automerge bot!

I considered the following status checks when analyzing this PR:

  • linter: passed
  • azure: passed

Thus the PR was passing and merged! Have a great day!

@jakirkham jakirkham removed the automerge Merge the PR when CI passes label May 14, 2024
@jakirkham
Copy link
Member

CI was failing due to issue: conda-forge/status#177

So dropped automerge for the moment

Tried to push a test as well loosely based on a script we have used elsewhere. It may need tweaks though

@danpetry
Copy link
Contributor Author

Thanks for the reviews and the added tests.

@danpetry
Copy link
Contributor Author

Is this ready to go or does it need more changes? (aside from sorting out merge conflicts)

@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

@bdice
Copy link
Contributor

bdice commented Jul 23, 2024

I fixed conflicts and will enable automerge.

@bdice bdice added the automerge Merge the PR when CI passes label Jul 23, 2024
@github-actions github-actions bot merged commit 068f4d4 into conda-forge:main Jul 23, 2024
5 checks passed
@danpetry danpetry deleted the dpetry/rpath-not-runpath branch July 23, 2024 22:11
@jakirkham
Copy link
Member

Thanks all! 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Merge the PR when CI passes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants