Fix build of boost::iostreams zlib filter #115
Conversation
Explicitly add zlib to the requirements so that boost::iostreams gets built with the zlib filter. This was being pulled in implicitly at one point but recently stopped working; make it explicit. Add a compile+link test to make sure the final library includes the necessary symbols. Closes conda-forge#114.
…nda-forge-pinning 2022.02.05.21.28.19
benmwebb
requested review from
beckermr,
ccordoba12,
isuruf,
jakirkham,
jschueller,
msarahan,
ocefpaf and
xhochy
as code owners
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
recipe/run_test.sh
Outdated
| @@ -0,0 +1,8 @@ | |||
| # Skip compile tests if we are cross-compiling | |||
| if echo ${CONDA_TOOLCHAIN_HOST} | grep -q arm64-apple; then | |||
There was a problem hiding this comment.
| if echo ${CONDA_TOOLCHAIN_HOST} | grep -q arm64-apple; then | |
| if [[ "${CONDA_BUILD_CROSS_COMPILATION:-0}" == "1" && "${CMAKE_CROSSCOMPILING_EMULATOR:-}" == "" ]]; then |
There was a problem hiding this comment.
I had something like that earlier but it didn't work - looks like activate_clang_osx-arm64.sh unsets CONDA_BUILD_CROSS_COMPILATION when run in the test environment.
There was a problem hiding this comment.
That's weird, I'm using exactly this in the go-activation-feedstock.
There was a problem hiding this comment.
Indeed, you can see the failure at https://github.com/conda-forge/boost-cpp-feedstock/runs/5082034667 (and the corresponding run_test.sh). I can't see the Azure Pipelines logs right now (says "An unexpected error has occurred within this region of the page") but maybe it'll work for you. I'm certainly open to suggestions!
|
Hi! This is the friendly conda-forge automerge bot! I considered the following status checks when analyzing this PR:
Thus the PR was passing and merged! Have a great day! |
Explicitly add zlib to the requirements so that boost::iostreams gets built with the zlib filter. This was being pulled in implicitly at one point but recently stopped working; make it explicit. Add a compile+link test to make sure the final library includes the necessary symbols. Closes conda-forge#122. This is essentially the same as PR conda-forge#115 (which fixed the issue for the 1.74.x branch) but for the main branch.
Explicitly add zlib to the requirements so that
boost::iostreams gets built with the zlib filter.
This was being pulled in implicitly at one point
but recently stopped working; make it explicit.
Add a compile+link test to make sure the final
library includes the necessary symbols. Closes #114.
Checklist
conda-smithy(Use the phrase@conda-forge-admin, please rerenderin a comment in this PR for automated rerendering)