Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Quarto packages affected by packaging bug #774

Merged

Conversation

mfisher87
Copy link
Member

@mfisher87 mfisher87 commented Jul 28, 2023

Hello, I'm sad to request a large number of Quarto packages to be removed from conda-forge.

We found that a patch was causing unintended (and very bad) behavior when using Quarto to install TinyTeX. The intent of the patch was to enable the Quarto conda package to install TinyTex into the current conda environment instead of to the path Quarto normally uses, ~/.TinyTex. The unintended result of the patch was that quarto install tinytex overwrites the entire conda environment with a TinyTeX installation.

A discussion between feedstock maintainer and Quarto devs yielded a decision to remove that patch. Quarto's own packages and conda-forge packages will all look for TinyTeX in, and install TinyTeX to, the same ~/.TinyTeX location. Versions 1.3.433-1 and 1.3.427-2 were released to fix the latest versions.

Long-term, we want to enable the Quarto conda package to get its TinyTeX dependency from conda-forge.

For discussion on marking these packages broken by packaging maintainers and Quarto devs, start here:

conda-forge/quarto-feedstock#25

❤️ Thank you for your time!

Guidelines for marking packages as broken:

  • We prefer to patch the repo data (see here)
    instead of marking packages as broken. This alternative workflow makes environments more reproducible.
  • Packages with requirements/metadata that are too strict but otherwise work are
    not technically broken and should not be marked as such.
  • Packages with missing metadata can be marked as broken on a temporary basis
    but should be patched in the repo data and be marked unbroken later.
  • In some cases where the number of users of a package is small or it is used by
    the maintainers only, we can allow packages to be marked broken more liberally.
  • We (conda-forge/core) try to make a decision on these requests within 24 hours.

What will happen when a package is marked broken?

  • Our bots will add the broken label to the package. The main label will remain on the package and this is normal.
  • Our bots will rebuild our repodata patches to remove this package from the repodata.
  • In a few hours after the anaconda.org CDN picks up the new patches, you will no longer be able to install the package from the main channel.

Checklist:

  • I want to mark a package as broken (or not broken):
    • Make sure your package is in the right spot (broken/* for adding the
      broken label, not_broken/* for removing the broken label, or token_reset/*
      for token resets)
    • Added a description of the problem with the package in the PR description.
    • Pinged the team for the package for their input.

For discussion by packaging maintainers and Quarto devs, start here:

conda-forge/quarto-feedstock#25
@mfisher87 mfisher87 requested a review from a team as a code owner July 28, 2023 20:46
@mfisher87
Copy link
Member Author

@conda-forge/core is there anything I can do to help make a decision on this request?

Thanks for your time :)

@beckermr beckermr merged commit 05c242f into conda-forge:main Aug 5, 2023
1 check passed
@mfisher87 mfisher87 deleted the quarto-feedstock-issue-25-broken-pkgs branch August 5, 2023 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants