Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark pint 0.24 build 0 as broken #1017

Closed
wants to merge 1 commit into from
Closed

Mark pint 0.24 build 0 as broken #1017

wants to merge 1 commit into from

Conversation

jan-janssen
Copy link
Member

@jan-janssen jan-janssen commented Jun 12, 2024

The pint package is released as noarch but dropped support for python 3.9 as reported in conda-forge/pint-feedstock#65 . A new build was released conda-forge/pint-feedstock#66 but on Python 3.9 conda still tries to install the previous build, so it should be marked as broken.

Guidelines for marking packages as broken:

  • We prefer to patch the repo data (see here)
    instead of marking packages as broken. This alternative workflow makes environments more reproducible.
  • Packages with requirements/metadata that are too strict but otherwise work are
    not technically broken and should not be marked as such.
  • Packages with missing metadata can be marked as broken on a temporary basis
    but should be patched in the repo data and be marked unbroken later.
  • In some cases where the number of users of a package is small or it is used by
    the maintainers only, we can allow packages to be marked broken more liberally.
  • We (conda-forge/core) try to make a decision on these requests within 24 hours.

What will happen when a package is marked broken?

  • Our bots will add the broken label to the package. The main label will remain on the package and this is normal.
  • Our bots will rebuild our repodata patches to remove this package from the repodata.
  • In a few hours after the anaconda.org CDN picks up the new patches, you will no longer be able to install the package from the main channel.

Checklist:

  • I want to mark a package as broken (or not broken):

    • Added a description of the problem with the package in the PR description.
    • Pinged the team for the package for their input.
  • I want to archive a feedstock:

    • Pinged the team for that feedstock for their input.
    • Make sure you have opened an issue on the feedstock explaining why it was archived.
    • Linked that issue in this PR description.
    • Added links to any other relevant issues/PRs in the PR description.
  • I want to request (or revoke) access to an opt-in CI resource:

    • Pinged the relevant feedstock team(s)
    • Added a small description explaining why access is needed

The pint package is released as `noarch` but dropped support for python 3.9 as reported in conda-forge/pint-feedstock#65 . A new build was released conda-forge/pint-feedstock#66 but on Python 3.9 conda still tries to install the previous build, so it should be marked as broken.
@jan-janssen jan-janssen requested a review from a team as a code owner June 12, 2024 05:24
@jan-janssen
Copy link
Member Author

@conda-forge/pint

@ocefpaf
Copy link
Member

ocefpaf commented Jun 12, 2024

We should do a repo data patch instead. Do you want to try it?

It should be something like this one: https://github.com/conda-forge/conda-forge-repodata-patches-feedstock/pull/591/files

@jan-janssen
Copy link
Member Author

We should do a repo data patch instead. Do you want to try it?

It should be something like this one: https://github.com/conda-forge/conda-forge-repodata-patches-feedstock/pull/591/files

@ocefpaf I created a corresponding pull request conda-forge/conda-forge-repodata-patches-feedstock#776

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants