fix for recent nightlies' TestOpts change #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Clippy failure wise... yeah, it will fail on stable. It's using unstable nightly APIs that are different between nightly and stable, it literally cannot pass clippy stable. The other two problems are fixed in the other PR. Edit: not now that I conditionally included the change using version_check. |
... about the using the specialization feature. datatest can't only use min_specialization, apparently (I tried this).
https://doc.rust-lang.org/stable/test/struct.TestOpts.html vs https://doc.rust-lang.org/nightly/test/struct.TestOpts.html The `filter: Option<String>` field was changed to `filters: Vec<String>`. So this revision uses version_check to determine whether libtest has that update. Makes it compile on both stable (1.50) and nightly (1.52) at the time of writing.
It disabled too much stuff through the use of a non-existent cfg(feature="stable"). That now exists as feature="rustc_is_stable", same with rustc_is_nightly. Then, allows test_case_registration to become a default feature. Essentially guards its use in cfg() with &= rustc_is_nightly, so stable users do not have to --no-default-features. Each test suite has instructions for running it at the top now.
|
Ok, so a few updates:
|
Closed
|
Used this PR in my project and it solved the compile issue and runs the data-dependent tests successfully. |
|
I'll be sure to keep my main branch clean so that keeps working until this is merged. |
|
Hi! Any estimation on when this could get merged? |
|
Thanks for merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See rust-lang/rust#81356. The
filter: Option<String>field was changed tofilters: Vec<String>.