Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve type definitions for jwtDecode and createAssertion #77

Merged
merged 5 commits into from
Apr 17, 2024
Merged

Improve type definitions for jwtDecode and createAssertion #77

merged 5 commits into from
Apr 17, 2024

Conversation

marcomontalbano
Copy link
Member

@marcomontalbano marcomontalbano commented Apr 16, 2024 •
edited
Loading

What I did

I improved the type definitions for jwtDecode and createAssertion.

Checklist

  • Make sure your changes are tested (stories and/or unit, integration, or end-to-end tests).
  • Make sure to add/update documentation regarding your changes.
  • You are NOT deprecating/removing a feature.

@marcomontalbano marcomontalbano changed the title Improve tests Improve type definitions for jwtDecode and JWT Bearer Apr 16, 2024
@marcomontalbano marcomontalbano changed the title Improve type definitions for jwtDecode and JWT Bearer Improve type definitions for jwtDecode and createAssertion Apr 16, 2024
@marcomontalbano marcomontalbano self-assigned this Apr 16, 2024
@marcomontalbano marcomontalbano added the enhancement New feature or request label Apr 16, 2024
@marcomontalbano marcomontalbano marked this pull request as ready for review April 17, 2024 08:14
@marcomontalbano marcomontalbano merged commit 16797bb into main Apr 17, 2024
@marcomontalbano marcomontalbano deleted the improve-tests branch April 17, 2024 08:44
@marcomontalbano marcomontalbano added bug Something isn't working and removed enhancement New feature or request labels Apr 17, 2024
This was referenced Sep 14, 2024
Open
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clgiovannelli clgiovannelli clgiovannelli approved these changes

Assignees

@marcomontalbano marcomontalbano

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marcomontalbano @clgiovannelli