GM: Switch to AcceleratorPedal2 #23280
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
FYI - the failures are Mazda related, doesn't look like there were any GM issues |
|
@adeebshihadeh per your request in the Panda PR, how should I go about providing the necessary validation? FYI - These PRs are extracted from a more comprehensive fork; technically nobody is driving with just the individual pieces, and we have not merged enough functionality to even test one of the new vehicles. Not complaining - just looking for guidance. How does this normally work? |
|
I couldn't push to your branch for some reason so moved this to #23376. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description [] Update carstate to use AcceleratorPedal2 for gas and remove the requirement for AcceleratorPedal. The Pedal value in the two messages is identical, but AcceleratorPedal is not present on the 2020 Silverado.
Verification [] Has been running without issue on several vehicles. I also checked all the fingerprints to confirm that if 417 is present, 452 is also -- meaning it is unlikely to cause any problems. passes testing.
Pairs with Panda PR commaai/panda#813