Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

c docs to docs.comma.ai #23204

Closed
wants to merge 11 commits into from
Closed

c docs to docs.comma.ai #23204

wants to merge 11 commits into from

Conversation

tecandrew
Copy link
Contributor

@tecandrew tecandrew commented Dec 13, 2021

Overview

redo of PR #22751
rel: #22732

Features

  • add c docs to https://docs.comma.ai
    • doxygen-based documentation using sphinx and breathe
  • adds some SEO stuff
  • make it look prettier

image

Misc

  • uses cmake instead of Makefile
    • initially used to auto-generate all C code using traditional doxygen/cmake template, but sphinx-breathe doesn't like some code (selfdrive/ui/qt, selfdrive/ui/widgets)
      • now only documents explicitly listed files in docs/sphinx/c_docs.rst.in
  • regenerates Pipfile.lock, adding breathe module

@tecandrew tecandrew marked this pull request as ready for review December 13, 2021 05:30
@pd0wm
Copy link
Contributor

pd0wm commented Dec 13, 2021

Nice!

Same comments as on the previous PR:

  1. Can you convert the cmake build file into scons instead of introducing another build system? If you can't figure it out I can take a look as well.
  2. Can we only check in the parts of the Doxyfile.in that are not the default settings?

@pd0wm pd0wm added the docs label Dec 13, 2021
@tecandrew
Copy link
Contributor Author

tecandrew commented Dec 13, 2021

Nice!

Same comments as on the previous PR:

  1. Can you convert the cmake build file into scons instead of introducing another build system? If you can't figure it out I can take a look as well.

  2. Can we only check in the parts of the Doxyfile.in that are not the default settings?

I'll take a stab at scons. Might take a while to convert since i've never dev'd with it before

Not sure what you meant by the last point. 😅

@pd0wm
Copy link
Contributor

pd0wm commented Dec 13, 2021

You added a 2600 line file that only contains the default settings. Does it also work if you only add the options that we actually change?

@tecandrew
Copy link
Contributor Author

tecandrew commented Dec 13, 2021

I should take that out: sphinx is doing the XML creation, not doxygen Doxyfile explicitly. it's generating docs based off found .h and .c pairs. docs/sphinx/conf.py.in

@adeebshihadeh
Copy link
Contributor

Can you split out all the listed features into their own PR?

@tecandrew
Copy link
Contributor Author

tecandrew commented Dec 15, 2021

Can you split out all the listed features into their own PR?

yeah, i could do that, but it'll be based off cmake in its current state.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants