-
Notifications
You must be signed in to change notification settings - Fork 9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
c docs to docs.comma.ai #23204
c docs to docs.comma.ai #23204
Conversation
- remove doxygen target (moved to sphinx-build)
* cleanup some code * add comments on full doxy build
* SEO metadata stuff * properly use cmake * add logo(s)
Nice! Same comments as on the previous PR:
|
I'll take a stab at scons. Might take a while to convert since i've never dev'd with it before Not sure what you meant by the last point. 😅 |
You added a 2600 line file that only contains the default settings. Does it also work if you only add the options that we actually change? |
I should take that out: sphinx is doing the XML creation, not doxygen Doxyfile explicitly. it's generating docs based off found .h and .c pairs. docs/sphinx/conf.py.in |
Can you split out all the listed features into their own PR? |
yeah, i could do that, but it'll be based off |
Overview
redo of PR #22751
rel: #22732
Features
sphinx
andbreathe
Misc
cmake
instead ofMakefile
doxygen/cmake
template, butsphinx-breathe
doesn't like some code (selfdrive/ui/qt, selfdrive/ui/widgets)docs/sphinx/c_docs.rst.in
Pipfile.lock
, addingbreathe
module