alert text simplification #23186
Merged
alert text simplification #23186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adeebshihadeh
force-pushed
the
alert-simplification
branch
from
4916ab5
to
0280b56
Compare
hewers
reviewed
Dec 10, 2021
| @@ -579,7 +586,7 @@ def joystick_alert(CP: car.CarParams, sm: messaging.SubMaster, metric: bool) -> | |||
| }, | |||
|
|
|||
| EventName.wrongGear: { | |||
| ET.SOFT_DISABLE: SoftDisableAlert("Gear not D"), | |||
| ET.SOFT_DISABLE: UserSoftDisableAlert("Gear not D"), | |||
| ET.NO_ENTRY: NoEntryAlert("Gear not D"), | |||
There was a problem hiding this comment.
I like how warnings give actions, like "touch wheel" and "take control".
Maybe NO_ENTRY should too, because action is required to engage: "Shift to Drive", "Close doors", "Fasten seatbelts"
There was a problem hiding this comment.
For soft disable, it's talking about past-tense "what happened", so those sound right.
Also I don't know the nitty gritty here so call out if I'm missing deets.
There was a problem hiding this comment.
I think it's fine as is since it's more a response to the engagement attempt. @alexcomma what do you think?
adeebshihadeh
commented
Dec 10, 2021
adeebshihadeh
force-pushed
the
alert-simplification
branch
from
1295c00
to
a7082cd
Compare
twilsonco
pushed a commit
to twilsonco/openpilot
that referenced
this pull request
Feb 13, 2022
* alert text simplification * little more * user triggered * little more * less annoying ldw * Update selfdrive/controls/lib/events.py * update refs * revert
twilsonco
pushed a commit
to twilsonco/openpilot
that referenced
this pull request
Feb 13, 2022
* alert text simplification * little more * user triggered * little more * less annoying ldw * Update selfdrive/controls/lib/events.py * update refs * revert
twilsonco
pushed a commit
to twilsonco/openpilot
that referenced
this pull request
Feb 14, 2022
* alert text simplification * little more * user triggered * little more * less annoying ldw * Update selfdrive/controls/lib/events.py * update refs * revert
twilsonco
pushed a commit
to twilsonco/openpilot
that referenced
this pull request
Feb 16, 2022
* alert text simplification * little more * user triggered * little more * less annoying ldw * Update selfdrive/controls/lib/events.py * update refs * revert
twilsonco
pushed a commit
to twilsonco/openpilot
that referenced
this pull request
Feb 17, 2022
* alert text simplification * little more * user triggered * little more * less annoying ldw * Update selfdrive/controls/lib/events.py * update refs * revert
dkiiv
added a commit
to dkiiv/openpilot
that referenced
this pull request
Jun 13, 2022
* revert to old red alert sound for now (commaai#23182) * Added sbigmodel frame transformations * alert text simplification (commaai#23186) * alert text simplification * little more * user triggered * little more * less annoying ldw * Update selfdrive/controls/lib/events.py * update refs * revert * alerts: handle min duration properly (commaai#23191) * alerts: handle min duration properly * add active * tests * cleanup test * update refs * fix missing time import * updated: handle execptions while setting params * update release notes * add honda bosch hud msgs to release notes * Update RELEASES.md * RELEASES.md: prevention is a bold statement * Revert "soundd: use setLoopCount(0) to stop repeating sound (commaai#23076)" This reverts commit 3588574. * alerts: escalate soft disable alert near disengagement (commaai#23198) * alerts: escalate soft disable alert if resulted in disengagement * show 0.5s before disengagement * model output struct for metadata (commaai#23139) * model output struct for metadata * better max element search * ModelDataRawDesireProb.to_array() * eliminate some copies * not worth messing with softmax now * remove unused includes * more cleanup * no longer pointers * better variable name * fix recurrent state * improve variable name * fix OUTPUT_SIZE and NET_OUTPUT_SIZE * increase cruise mismatch threshold * update refs * util: move all functions into util namespace (commaai#23203) * RawLogger: fix wrong pts (commaai#23205) * Use std::unique_ptr to manage memory (commaai#23168) * use unique_ptr * trigger ci * move down loggerdstate * commonmodel.h: move global model size into class ModelFrame (commaai#23193) * move to class ModelFrame * remove defines in dmonitoring as well Co-authored-by: Willem Melching <willem.melching@gmail.com> * common_process_driver_camera: same parameters as process_thread_cb (commaai#23202) * replay: use std::unique_ptr to manage memory, reuse events buffer. (commaai#23049) * reuse events buffer * Trigger Build * LapConv: remove hardcoded FULL_STRIDE_X (commaai#23200) * fix wroing stride_x * remove hardcoded rgb_stride * Qt/SetingWindow: faster initialization and painting (commaai#21764) * reduce init time from ~520ms to ~350ms * faster init toggle setfixedheight in ctor delay init TogglesPanel,reduce init time to ~180ms cleanup * precise style, reduce to ~100ms * revert 'faster toggle * fix horizontal_line * fix background * cleanup * add small minimum time between taps to onboarding (commaai#23212) Co-authored-by: Comma Device <device@comma.ai> * androidd: reduce cloudlog spam * update contributing.md * Updated release notes * bump version to 0.8.13 * move LayoutWidget,ClickableWidget to controls (commaai#23207) * UI: add timeout to close settings window while onroad (commaai#22980) * refactor updateWakefulness * don't hide sidebar * rename reset->reset_timeout * move related variables and functions into class Device * reset timeout in ctor * set timeout to 10s if ignition is on * cleanup * remove unused QTimer *timer * check getTimestamp * keep socket reading in update_state * keep filtering Co-authored-by: Willem Melching <willem.melching@gmail.com> * C2: display ip address in network panel (commaai#23215) * display ipv4 address * refactor to class * only display ip address * version.py: make function names more clear (commaai#23216) * rename a few version functions * and is_prebuilt * and some formatting 😊 * athena: persist upload queue to disk (commaai#22659) * revert submodules * lowercase * addressed comments * add test for cancelled uploads * formatting * catch all exceptions * handle empty param Co-authored-by: Willem Melching <willem.melching@gmail.com> * comma two: remove lens sag compensation (commaai#23113) * put logcat in bootlog (commaai#23217) * put logcat in boot log * continue * use std::unique_ptr * Revert "use std::unique_ptr" This reverts commit c671f8c. * Remove minSpeedCan (commaai#22991) * Remove minCanSpeed Remove minCanSpeed * it actually only goes out to 2.5 seconds, this is okay to remove * test to see if this preserves behavior add minSpeedCan * Revert "test to see if this preserves behavior" This reverts commit 31b11f0. * preserve behavior (don't enter stopping as early) * vEgoStopping needs to be less than or equal to vEgoStarting to avoid state oscillation * DM: more adaptive pose policy (commaai#23184) * rename and add dep * proto thresholds * tweak vk * update natural offset and clip offsets * 95th looks good * no punish for being relaxed * yaw laplace only * some pay more attention * update ref Co-authored-by: Willem Melching <willem.melching@gmail.com> * seems to be flipped (commaai#23213) * Update ref with minSpeedCAN removed * Dont use erratic current block (commaai#23211) * Revert "Dont use erratic current block (commaai#23211)" (commaai#23221) This reverts commit 19335bb. * Calibrationd: don't use noisy current block (commaai#23222) * Calibrationd: check size of valid_blocks without current (commaai#23223) * Toyota: Display Blue Barriers When Engaged, Matches OEM Design (commaai#23150) * modeld: start publishing before calib seen (commaai#23190) * cloudlog: add daemon name to context for python daemons (commaai#23225) * python * manager is a daemon too * Update selfdrive/manager/process.py Co-authored-by: Comma Device <device@comma.ai> * Subaru Pre-Global: Rename ES_CruiseThrottle to ES_Distance (commaai#23024) * Rename preglobal ES_CruiseThrottle to ES_Distance * bump opendbc Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com> * ui: singleton uistate (commaai#22789) * singleton uistate * merge master * merge master * merge master * connect uistate in sidebar * move to device * selfdrive/version: remove one unnecessary write to .git/ (commaai#23183) * qt/util: new function scaledPixmap (commaai#23103) * new function scaledPixmap * rename to loadpixmap * driving.h: remove obsolete poly_fit function prototype (commaai#23229) * modeld: make valid variable thread safe (commaai#23228) * manage_athenad.py: add daemon argument to launcher * Revert "Qt/SetingWindow: faster initialization and painting (commaai#21764)" This reverts commit f482354. * UI: always clear CameraView background (commaai#23231) * fix background * gate that with Hardware::EON * always call glclear * VW MQB: Add FW for 2018 Škoda Superb (commaai#23233) * soundd: back to onroad only (commaai#23236) * Subaru: Add Impreza/Crosstrek 2020 (commaai#21011) * Add Subaru Impreza/Crosstrek 2020 * Update selfdrive/test/test_routes.py Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com> * model replay: more consistent replay (commaai#23237) * first cleanup * don't send calib and desire * should always be valid * little more * framereader: use the same alignement as visionbuf (commaai#23208) * aligned rgb buffer * fix yuv stride * boardd: add controls heartbeat (commaai#23185) * boardd: add controls heartbeat * bump panda * bump again * bump panda * Log actuators after applying rate limits in CarController (commaai#23230) * return actuators from carcontroller * log it * pass to latcontrol * chrysler * gm * honda * more brands * rest of the brands * gm cleanup * hyundai cleanup * update ref * rename field * fix subaru * add types * more subaru fixes commaai#23240 * consistent whitespace * bump cereal * Convert format strings strings to f-strings (commaai#23241) * Convert all text strings to f-strings Reformats all the text from the old "%-formatted" and .format(...) format to the newer f-string format, as defined in PEP 498. This requires Python 3.6+. Flynt 0.69 was used to reformat the strings. 120 f-strings were created in 51 files. F-strings are in general more readable, concise and performant. See also: https://www.python.org/dev/peps/pep-0498/#rationale * revert pyextra changes * revert ublox.py Co-authored-by: Willem Melching <willem.melching@gmail.com> * Abstract classes inherit from ABC (commaai#23246) * Disable AWV for now * bremse8 filter * panda fix * fix panda * panda * fix bremse_8 * update release notes * modeldata: use a constexpr function to build the IDXS (commaai#23245) remove convert_array_to_type rename to build_idxs space double * update model replay ref commit after increased model idx precision * boardd: new class USBDevice (commaai#23015) * USBDevice * merge master * rebase master * add to fiels_common * inline functions * namespace * init err * remove nested if * cleanup * bump panda for branch * change includes * bump panda branch * change name * bump master panda Co-authored-by: Igor Biletskyy <briskspirit@users.noreply.github.com> Co-authored-by: Igor Biletskyy <bs@privacy.im> * Revert "boardd: new class USBDevice (commaai#23015)" This reverts commit 4061f50. * Road Roll Compensation Rebased (commaai#23251) * first commit * update refs * bremse_5 spoof * Fix Bremse_5 * remove bremse_5 * bremse_5 * modeld: update live calibration in main thread (commaai#23235) * update live calibration in main thread * static ground_from_medmodel_frame * more static * cleanup * no lambda * trigger ci * ui: remove variable world_objects_visible, use rcv_frame (commaai#23264) * First attempt mAWV filtering and autohold on standstill * remove Bremse_5 * Mazda: CX-5 and 3 FW (commaai#23267) * Mazda 3 2017 fw dongle id: f7fec643f5178df8 Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com> * Mazda CX-5 2020 FW dongle id: f4b488f06d3b7711 Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com> * mui * build for mac (commaai#23048) * fix mAWV not being send * Mazda CX-5 2021 FW (commaai#23270) dongle id: 661fdb17fa82339c Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com> * Mazda: alert when LKAS is disabled (commaai#23273) * Mazda: alert when LKAS is disabled Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com> * Update selfdrive/controls/lib/events.py * Update selfdrive/car/mazda/interface.py * bump cereal Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com> * Revert "Mazda: alert when LKAS is disabled (commaai#23273)" This reverts commit f25121b. * bump cereal * repeat immediate warning sound * delete old scripts * UI: less harsh controls unresponsive when not engaged * UI: call map::offroadTransition after creating map (commaai#23283) * make that consistent with other labels * use km/h in settings.cc (commaai#23290) * OnroadHud: use function loadPixmap (commaai#23292) * Add missing COROLLA_TSS2 ESP & engine f/w (commaai#23294) `Sebastiaan#0569` 2020 Corolla Hatch 1.2T XR RHD DongleID/route 567e47e503b36408|2021-12-22--20-44-44 * replay/camera: use existing YUV_BUFFER_COUNT (commaai#23297) * Add missing HIGHLANDER_TSS2 engine f/w (commaai#23301) `@JohnLips#7600` 2022 Highlander Platinum ICE DongleID/route 697a805960f1b2d5|2021-12-23--13-14-37 * VW MQB: Add FW for 2018 Volkswagen Arteon (commaai#23303) * Pyupgrade 3.6: Update syntax with Python 3.6+ features (commaai#23305) Updated Python code with Python 3.6+ features: - utf-8 encoding is now the default (PEP 3120) - Replace list comprehensions by Generator Expressions (PEP 289) - Replace yield loop by yield from (PEP 380) - Remove the (object) subclass when defining a class - Replace the IOError alias by OSError (PEP 3151) - Define sets with curly braces {} instead of set() - Remove "r" parameter from open function, which is default Co-Authored-By: Adeeb Shihadeh <8762862+adeebshihadeh@users.noreply.github.com> Co-Authored-By: GregorKikelj <96022003+GregorKikelj@users.noreply.github.com> Co-authored-by: Adeeb Shihadeh <8762862+adeebshihadeh@users.noreply.github.com> Co-authored-by: GregorKikelj <96022003+GregorKikelj@users.noreply.github.com> * VW MQB: Add FW for 2019 Volkswagen Jetta (commaai#23306) * fingerprint 2019 vw jetta sel * remove duplicate, fix sorting Co-authored-by: cyanet01 <richard@connectya.com> * test/profiler: fix setting carParams * replay: fix segfault or hanging on quit (commaai#23323) * replay/util: initialize curl at startup (commaai#23314) * posenet_publish: use const references (commaai#23310) * palanteer seems pretty cool * ui: set the bg color of controllerUnresponsivePermanent to blue (commaai#23308) * fix bg color * blue * replay: add flag REPLAY_FLAG_FULL_SPEED to play at full speed (commaai#23324) * add flag REPLAY_FLAG_FULL_SPEED * use hasFlag * replay/segment: pass member function pointer to QtConcurrent::run (commaai#23312) * LongitudinalMpc: minor clean up (commaai#23296) * correct order * formatting * Revert "formatting" This reverts commit 481c390. * use np.zeros * typos and formatting * typo * typo * Add More Types for mypy (commaai#23268) * mypy passes * a few more * a few in manager * more types, will lint * more * simple types * events type * Update selfdrive/thermald/thermald.py * Apply suggestions from code review Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com> * docs.comma.ai add sitemap and robots.txt (commaai#23259) * add sitemap generator * update conf for seo * remove cmake var * relock * fix html_baseurl * more fixes * newline Co-authored-by: Willem Melching <willem.melching@gmail.com> * add version to docs.comma.ai (commaai#23260) * update conf: * add logo and favicon from connect.comma.ai * add version * proper version extract * v * Update docs/conf.py Co-authored-by: Willem Melching <willem.melching@gmail.com> * mac_setup: install git-lfs * plotjuggler: add mac support (commaai#23344) * plotjuggler: add mac support * fix test? * update readme * oops * fix * cleanup * typo * works * little more * fix test * little faster * disable simulator job until LFS is fixed * Hyundai: Car Port for 2022 Santa Fe Plug-in Hybrid (commaai#23332) * Add car port: Hyundai Santa Fe Plug-in Hybrid 2022 * Add test route * fix setup scripts if git isn't installed * PC: dynamically set PYTHONPATH from real openpilot path (commaai#23322) * dynamic PYTHONPATH setting based on actual openpilot location * right above * fix path * absolute path all the time * Revert "absolute path all the time" This reverts commit c0bc2e0. * Update tools/openpilot_env.sh Co-authored-by: Willem Melching <willem.melching@gmail.com> Co-authored-by: Willem Melching <willem.melching@gmail.com> * plotjuggler: fix layout param (commaai#23348) * replay: add flag to disable video (commaai#23353) * lateral_planner.py/publish: follow capnp best practices (commaai#23359) * LogReader: add arg to sort by time (commaai#23346) * logreader optional sort by time * robust logreader sort by time option * CI: use ubuntu_setup.sh (commaai#23349) * CI: use ubuntu_setup.sh * works? * need to fix paths * set paths * no batman for now * pyenv version * rehash after install packages * unify python install * revert that * fix pyenv path * no pipenv * flip that * fix rehash * skip that * revert panda * first contribution ideas * MultiLogIterator: remove wraparound mode (commaai#23360) * HKG: blacklist cars with lower steering max (commaai#23255) * HKG: Add Lower Steering Torque Cars to STEER_MAX = 255 Blacklist * add comment Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com> * MultiLogIterator: fix after adding sort_by_time * Add firmware from 2021 prius in australia (commaai#23271) Discord user khalid.auslink#0024 / shah#3880 FW from: 49708c324cfe37cb%7C2021-12-20--04-14-26 * HKG: Add and Fix FW for 2022 Kia Niro EV (commaai#23253) * Remove non-exist esp FW from Niro_EV * HKG: Add FW for 2022 Kia Niro EV * Add 2022 Kia Niro EV to STEER_MAX = 384 * Update CARS.md * HKG: Add FW for 2022 Kia Niro EV * Remove duplicate FW version * Remove duplicate FW versions from 0.8.3 FW dump (commaai#20702) * Fix FW versions spacing * Fix FW versions spacing * Add additional FW version Co-authored-by: Willem Melching <willem.melching@gmail.com> * add supported FW version for Palisade 2022 (commaai#23337) * Toyota: merge Lexus RX params (commaai#23374) * Toyota: merge Lexus RX params * pick tuning * add those back * Toyota: 2020 Highlander Hybrid Engine fingerprint (commaai#23373) * CAN receive error is a comm issue (commaai#23362) * CI: cache LFS objects (commaai#23345) * ui: update lead's z position if modelV2 has been updated after startup. (commaai#23355) * model frame >= started_frame * remove optional * lane_planner.py/parse_model: follow capnp best practices (commaai#23368) * pre-commit: fix exclude patterns (commaai#23375) * GM: Switch to AcceleratorPedal2 (commaai#23376) * GM: Switch to AcceleratorPedal2 * bump panda Co-authored-by: Jason Shuler <jshuler@gmail.com> * CI: run car unit tests in parallel (commaai#23379) * CI: run car unit tests in parallel * move that * Revert "soundd: back to onroad only (commaai#23236)" This reverts commit 3bdb445. * radard/update: optimize capnp (commaai#23380) * ui: emit offroadTransition in UIState::updateStatus (commaai#23265) * replay tests: retry on network failure (commaai#23383) * tools: configure PYTHONPATH in pipenv (commaai#23361) * automatically set PYTHONPATH in pipenv * remove other place this was set * Fix steering oscillations in 2019 RDX (commaai#22677) Steering wheel would oscillate quickly when going straight, oscillation is gone after this modification. * Subaru FPv2 support (commaai#1878) * Add Subaru FPv2 support * Add Subaru Ascent and Impreza FPv2 values * Remove 10 second delay, use UDS for Subaru FPv2 * before VW * before hyundai Co-authored-by: Willem Melching <willem.melching@gmail.com> * add subaru fp2.0 to release notes * longcontrol/update: optimize capnp (commaai#23382) * interfaces/apply: follow capnp best practices (commaai#23371) * bump panda * ui/update_model: do not recalculate the max_idx If there is no lead (commaai#23356) * controlsd/publish_logs: follow capnp best practices (commaai#23372) * follow follow capnp best practices * cleanup * ui/get_path_length_idx: line_x[i] shoud be less than or equal to path_height (commaai#23336) * start loop index from 1 * use islessequal * use build in <= * Add comment about vEgoStarting to interfaces (commaai#23327) * replay/logreader: handle abort in load (commaai#23321) * handle abort * handle abort in decompressBZ2 * logcatd: fix sd_journal_seek_tail doesn't go to end (commaai#23319) * fix sd_journal_seek_tail doesn't go to end * add comment * MUI should be a status bar (commaai#23287) * Longitudinal planner: make v_desired a FirstOrderFilter (commaai#23341) * make v_desired a FirstOrderFilter * forgot one * one more ref * Add a new object for the filter * fix * fix tests * update ref Co-authored-by: Willem Melching <willem.melching@gmail.com> * UI: run set_brightness in QtConcurrent (commaai#23326) * use QFuture * update at 10 hz * don't change frequency * CameraView: sync pbo with glFence instead of calling glFinish (commaai#23293) * Sync pbo with fence * use std::unique_ptr * Joystick: learn axis min/max (commaai#23377) * Joystick: learn axis min/max * clean up updating max/min Co-authored-by: Willem Melching <willem.melching@gmail.com> * disable pytest concurrency for test_models * cameraview.cc: call glFlush after creating fence * plotjuggler: support segment names (commaai#23263) * plotjuggler: support segment names * update docs * generic parser * convert segment number to int when parsing * add SegmentName Co-authored-by: Willem Melching <willem.melching@gmail.com> * LongitudinalMpc: Remove class accel_limit_arr (commaai#23295) * remove class accel_limit_arr remove class accel_limit_arr * make it static * only set static parameters once * just use existing function style * Update selfdrive/controls/lib/longitudinal_mpc_lib/long_mpc.py * Update selfdrive/controls/lib/longitudinal_mpc_lib/long_mpc.py Co-authored-by: Willem Melching <willem.melching@gmail.com> * replay: Add next engagement / disengagement jump capabilities (commaai#23248) * seek engament/disengament in qlogs * cleanup * cleanup * little more * add output * remove qinfo * fix typo * do nothing if tm less than current mono time * const * short variable name * lgtm * Toyota: only send gas interceptor message when openpilot controls longitudinal (commaai#23357) * Toyota: gate enableGasInterceptor behind openpilotLongitudinalControl * fix carcontroller typo * Revert "Toyota: gate enableGasInterceptor behind openpilotLongitudinalControl" This reverts commit a974e8f. * put condition in carcontroller * gate building can messages Co-authored-by: Willem Melching <willem.melching@gmail.com> * bump CPU usage slightly after adding glFlush * athena: methods for adding and cancelling multiple upload requests (commaai#23366) * multiple upload cancel * multiple uploads athena method * cleanup * cleanup * more cleanup * isnt used * fix test * actually fix test * docs: setup docs for C code (commaai#23262) * add breathe and doxygen * add sphinx-breathe c docs generation * add c docs to site * built in docker * build base image first * namespace cleanup * Revert "build base image first" This reverts commit 4c44c02. * its in the dockerfile Co-authored-by: Willem Melching <willem.melching@gmail.com> * docs: conf.py dont shadow project variable * Subaru: initial FPv2 dump (commaai#23389) * Add FPv2 for Ascent, Forester, Impreza, Legacy, Outback * remove comments * Controlsd: fix bug in curv rate limit (commaai#23250) * Controlsd: fix bug in curv rate limit * update ref * Move over all tss2 long tunes (commaai#23108) * add all rest * just commit to all TSS2 * forgot this line * controlsd: remove duplicate event relayMalfunction (commaai#23392) * Longcontrol: remove starting state (commaai#23328) * remove starting state * new ref * ready for merge * try this * cereal now on master Co-authored-by: Harald Schafer <harald.the.engineer@gmail.com> * paramsd: follow capnp best practices (commaai#23399) * fix up tools readme * Revert "cameraview.cc: call glFlush after creating fence" This reverts commit 8655f6d. * Revert "CameraView: sync pbo with glFence instead of calling glFinish (commaai#23293)" This reverts commit 5dbdad3. * setup: update pyenv before installing python (commaai#23405) * setup: remove duplicate pipenv install (commaai#23406) * longcontrol: check if speeds is empty (commaai#23410) * check if speeds is empty * move into existing check Co-authored-by: Willem Melching <willem.melching@gmail.com> * catch gl_buffer->map() returning nullptr (commaai#23411) * athena: uploads, show which items fail on error (commaai#23412) * athena: uploads, show which items fail on error * fix upload-id * no more 404 * Update selfdrive/athena/athenad.py Co-authored-by: Willem Melching <willem.melching@gmail.com> * replay: add missing import for std::optional (commaai#23416) * Add Prius 2022 to CARS.md (commaai#23417) Anecdote that this is working: https://discord.com/channels/469524606043160576/524327905937850394/928164186326982686 * Hyundai: Add Niro EV to 384 STEER_MAX (commaai#23420) * Niro EV confirmed working with 384 * SCC + LKAS is standard * Subaru: remove Ascent FPv1 (commaai#23407) * Remove Ascent FPv1 * bump cereal * Subaru: remove all Pre-Global CAN fingerprints (commaai#23422) * bump panda * GM: move abandoned cars into dashcam only (commaai#23423) * selfdrive/car/gm/interface.py: fix typo in comment (commaai#23429) spelling * controlsd/state_transition: remove redundant check in elif (commaai#23428) * replay: handle abort in getRemoteFileSize (commaai#23427) * locationd: disable falling device detector (commaai#23431) * skip falling device test * log ERROR messages in qlogs too (commaai#23425) * log ERROR messages in qlogs too * own event * bump cereal Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com> * fix typo in athena/registration.py (commaai#23434) * Camera transforms: denormalize with no bounds * Camera transforms: denormalize with no bounds at all * optimize alertmanager (commaai#23433) * Revert "ui/update_model: do not recalculate the max_idx If there is no lead (commaai#23356)" This reverts commit f561d84. * CameraView: sync pbo with glFence instead of calling glFinish (commaai#23409) * CameraView: sync pbo with glFence instead of calling glFinish (commaai#23293) * Sync pbo with fence * use std::unique_ptr * cameraview.cc: call glFlush after creating fence Co-authored-by: Dean Lee <deanlee3@gmail.com> * remove timebomb bypass/min steer speed 0km/ * testing * Revert "testing" * Update carcontroller.py * tools: update README.md (commaai#23447) * mac: fix setup and re-enable CI (commaai#23365) * rework mac_setup.sh * ignore casadi and onnx runtime in pipfile for Darwin * remove rust stuff * build and install casadi * add wget * explicit python3. dont do onnx just yet * resource compiler * replace acados Darwin lib w universal2 libs * relock Pipfile using linux machine * Update update_requirements.sh brackets * Update update_requirements.sh oops * ci: re-enable mac build * attempt to fix ci build: * pip stuff? * move rcc bin path to env script * oops * only mac * k im lazy. does ci like this?? * huh?? * * use curl * avoid casadi rebuilds * add comment to remove protobuf * host detect typo * python version * how did the builds not use swig? * better reinstall check * sometimes mac clang complain abt error limit * ci: build OP in venv * ci: bump to Big Sur * retry? idk why it failed @ acados link * * use macos-latest * move rcc path to scons * add extra paths for odd homebrew installs * acados source change * update macOS README * uh, maybe? * k nvm * ci: ok this is strange. might be scons bug? * fix conflicts: bump * just add cppcheck for pre-commit stuff * agane * cleanup * try that * fix path * no pyenv update on mac * source * fix rpath prefix? * no examples * fix exit * let's get this cached * add virtualenvs to cache * why did we cache that * let's see what's big * more * always ruyn * cache scons cache * better cache key * fix for partial hit * why so long Co-authored-by: Andrew Tec <andrest@trabus.com> Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com> Co-authored-by: Bruce Wayne <batman@openpilot-mac-mini.local> * LFS migration (commaai#23448) * lfs url in .lfsconfig * lfs push script * merge master * Merge master * hyundai enable radar points script cleanup (commaai#23451) * Update rednose_repo * repo * submodules * fix car * fix panda * remove werror * fix controls * fix values * accel fix * fix ceral * fix ldw * fix ldw * fix controls * smart power * Update carcontroller.py AWV_Halten at 10km/h * Update interface.py * Less l/100km * Update carcontroller.py Hopefully better low speed behaviour * tuning long * Fix MOB logic, Now matches OEM * lateral tuning Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com> Co-authored-by: mitchellgoffpc <mitchellgoffpc@gmail.com> Co-authored-by: HaraldSchafer <harald.the.engineer@gmail.com> Co-authored-by: George Hotz <george@comma.ai> Co-authored-by: Greg Hogan <gregjhogan@gmail.com> Co-authored-by: Dean Lee <deanlee3@gmail.com> Co-authored-by: Willem Melching <willem.melching@gmail.com> Co-authored-by: Comma Device <device@comma.ai> Co-authored-by: Shane Smiskol <shane@smiskol.com> Co-authored-by: Devin Leamy <devinleamy@gmail.com> Co-authored-by: ZwX1616 <zwx1616@gmail.com> Co-authored-by: Kevin Robert Keegan <kevin@krkeegan.com> Co-authored-by: martinl <martin@mlp.ee> Co-authored-by: Jason Young <46612682+jyoung8607@users.noreply.github.com> Co-authored-by: Ewout ter Hoeven <E.M.terHoeven@student.tudelft.nl> Co-authored-by: mike <mike@mikesantifort.nl> Co-authored-by: Igor Biletskyy <briskspirit@users.noreply.github.com> Co-authored-by: Igor Biletskyy <bs@privacy.im> Co-authored-by: Edgy <mikesantifort@gmail.com> Co-authored-by: Jafar Al-Gharaibeh <to.jafar@gmail.com> Co-authored-by: George Hotz <72895+geohot@users.noreply.github.com> Co-authored-by: cydia2020 <12470297+cydia2020@users.noreply.github.com> Co-authored-by: Erich Moraga <33645296+ErichMoraga@users.noreply.github.com> Co-authored-by: Adeeb Shihadeh <8762862+adeebshihadeh@users.noreply.github.com> Co-authored-by: GregorKikelj <96022003+GregorKikelj@users.noreply.github.com> Co-authored-by: cyanet01 <richard@connectya.com> Co-authored-by: Andrew <andrew.tec@pm.me> Co-authored-by: Jason Wen <47793918+sunnyhaibin@users.noreply.github.com> Co-authored-by: Nelson Chen <crazysim@gmail.com> Co-authored-by: Mr. V <41697569+pathocode@users.noreply.github.com> Co-authored-by: Matt Barclay <mbarclay@pm.me> Co-authored-by: Jason Shuler <jshuler@gmail.com> Co-authored-by: Anthony Foerster <anthonymfoerster@gmail.com> Co-authored-by: Robbe Derks <robbe.derks@gmail.com> Co-authored-by: Cameron Clough <cameronjclough@gmail.com> Co-authored-by: Joost Wooning <jwooning@gmail.com> Co-authored-by: Chris McCammon <chrismccammon123@gmail.com> Co-authored-by: kevinharbin <76784413+kevinharbin@users.noreply.github.com> Co-authored-by: grekiki <gregor1234567890@gmail.com> Co-authored-by: rzeydelis <bobbyzeydelis@gmail.com> Co-authored-by: Andrew Tec <andrest@trabus.com> Co-authored-by: Bruce Wayne <batman@openpilot-mac-mini.local> Co-authored-by: Mike Santifort <CineXMike@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.