Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VW MQB: Longitudinal prereqs #23004

Merged
merged 3 commits into from
Nov 22, 2021
Merged

Conversation

jyoung8607
Copy link
Collaborator

@jyoung8607 jyoung8607 commented Nov 22, 2021

Getting some of the diff noise / prerequisite pieces out of the way for VW MQB longitudinal:

  • Detect and alert on TSK faults as ACC faults (works and is useful for both stock and OP long)
  • Remember TSK (TreibStrang-Koordinator, drivetrain coordinator) state
  • Remember ABS/ESP hydraulic brake hold state
  • Apply fix from VW MQB: Fix for rare autoresume problems #22176 directly to button-spam code instead of standstill
  • Gate button-spam code behind CP.pcmCruise
  • Gate stock ACC setpoint handling behind CP.pcmCruise

@@ -190,6 +190,8 @@ def update(self, c, can_strings):
# Vehicle health and operation safety checks
if self.CS.parkingBrakeSet:
events.add(EventName.parkBrake)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

side ntoe: we should add this to carState and move this to the common events

@adeebshihadeh adeebshihadeh merged commit 819b7a1 into commaai:master Nov 22, 2021
@jyoung8607 jyoung8607 deleted the mqb-long-prereqs branch November 22, 2021 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants