visionbuf use EGL texture #310
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
June 1, 2022 17:25
jwooning
force-pushed
the
visionbuf_gl_texture
branch
from
4cf2f5e
to
a44e828
Compare
| @@ -117,6 +117,27 @@ void VisionBuf::init_cl(cl_device_id device_id, cl_context ctx) { | |||
| assert(err == 0); | |||
| } | |||
|
|
|||
| void VisionBuf::init_gl() { | |||
There was a problem hiding this comment.
any reason to do this here instead of UI?
There was a problem hiding this comment.
the image/texture is linked to the shared buffers, so it requires a texture pointer for every visionbuf object, so I guess it makes more sense to put it there
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for commaai/openpilot#24700