Add coarse grained lock around BSP requests to avoid deadlocks #3243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lefou
approved these changes
Jul 4, 2024
lihaoyi
added a commit
that referenced
this pull request
Sep 8, 2024
…ite sandboxing doc page, introduce `RunModule#runner` (#3479) Also did some misc cleanup: `synchronizedEval` is now unnecessary since #3243 added a coarse grained lock around BSP, prettied up the `#threadId` prefixes, remove empty `.dest/` folders for tidyness `RunModule#runner` continues the pattern estabilished with `CoursierModule#defaultResolver`: a convenient way to bundle up the various tasks related to running a modules code in a way that lets downstream callers pass things to `run` while being able to override the default configs (e.g. `forkEnv`, `forkArgs`, etc.) and without the hassle of wrapping things in `T.task`s. If this pattern works out, it would serve as a great alternative to the "pass tasks as arguments to command" pattern we've used in the past. This makes the `11-module-run-task` example much nicer Also more CI optimizations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3100, which for some reason is happening frequently enough on my laptop to really hamper my productivity. With a version of Mill built from this PR, the problem seems to have gone away.
We don't really have a strong concurrency model for what's meant to happen when multiple Mill commands are being evaluated at once, and trying to come up with one is a complex task that I don't think is worth the effort. Bazel works fine with a coarse-grained lock even for huge codebases and organizations, so this should do for Mill for now.
Pull request: #3243