Scoverage improve classpath override to the minimal #3122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It sounds like the failing test has nothing to do with this PR :( |
lolgab
reviewed
Apr 17, 2024
contrib/scoverage/src/mill/contrib/scoverage/ScoverageModule.scala
Outdated
Show resolved
Hide resolved
lefou
reviewed
Apr 19, 2024
contrib/scoverage/src/mill/contrib/scoverage/ScoverageModule.scala
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous version the
ScoverageTests.runClasspathwas more modified and reorganized.In this version, only the outer complied classes folder is replaced (in place) by the outer.scoverage complied classes folder.
An additional runtime dependency is also added:
org.scoverage::scalac-scoverage-runtime.All duplicated entries in the classpath are also removed.