feat: supports optional tuple elements #2708
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for guileless-rolypoly-866f8a ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
@colinhacks I think this one is a small footprint, no new features, just a fix. It adds functionality that many might presume already exists of the z.tuple() method. |
|
Thanks! I'm merging this as a starting point, but it'll undergo a lot of change before then. Some variant of this will land in Zod 4 but it'll be a while. |
colinhacks
force-pushed
the
support-optional-tuple-elements
branch
from
c2ce970
to
d3fedb1
Compare
colinhacks
added a commit
that referenced
this pull request
Apr 23, 2024
This reverts commit 32e05cf.
colinhacks
added a commit
to ytsunekawa/zod
that referenced
this pull request
May 3, 2024
* feat: supports optional tuple elements * fix: adds type assertions for optional elements in tuple * fix: minItems equals num elements before only optionals * fix: adds findMinItems() for tuple.minItems * Build deno --------- Co-authored-by: Colin McDonnell <colinmcd94@gmail.com>
colinhacks
added a commit
to ytsunekawa/zod
that referenced
this pull request
May 3, 2024
This reverts commit 32e05cf.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I see that the last test on tuples for this feature was commented out... hopefully just for want of a little more work?
Let me know?! Forgive me if there are any instructions I should have followed in creating this PR.
Also see the type assertions. I'm trying to use tuples as a schema for the params of a function with optional parameters. So
[number | undefined]won't match, it has to be something like[number?].