Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix regression in uniprot module #246

Merged
merged 1 commit into from
Jan 2, 2023
Merged

Fix regression in uniprot module #246

merged 1 commit into from
Jan 2, 2023

Conversation

cokelaer
Copy link
Owner

@cokelaer cokelaer commented Jan 2, 2023

Fixes also some regression in test (pride, wikipathway, panther, etc)

Fixes also some regression in test (pride, wikipathway, panther, etc)
@cokelaer
Copy link
Owner Author

cokelaer commented Jan 2, 2023

Fixes #245

@cokelaer cokelaer merged commit 4b05921 into main Jan 2, 2023

#https://github.com/cokelaer/bioservices/issues/245
def test_mapping_regression(uniprot):
uniprot.mapping("UniProtKB_AC-ID", "KEGG", "P43403,P123456")
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This wasn't the failing example. The failing example is the following: u.mapping("UniProtKB_AC-ID", "KEGG", "P43403")

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants