feat: Add IMF rules importer (#552) #571
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat: Add IMF rules importer A ned step for importing rules has been added. The step converts Information Modelling Framework (IMF) types, given as SHACL shapes, into rules. The new importer follows the compliance rules set by the OWL Importer, but most of the logic are, in this case, included the SPARQL queries. However, the validation checks are kept to ensure conformance. The IMF identifiers are given as UUIDs, but CDF does not allow identifiers starting with a number. All the relevant identifiers are therefore prefixed with "IMF_" IMF - attributes are properties that are described with several triples. An attribute contains relations to reference data describing the meaning of the attribute, as well as potential qualifiers and units of measure. To ensure that this information is included the attributes are created as both a class and property. This punning is required to ensure that both the usage of the attribute relative to an IMF block or terminal and the relationship to relevant reference data is captured. * fix: Update value type In cases where a sh:property points to a sh:class or a sh:qualifiedValueShape the corresponding value is set as the expected value type of the property. The logic should also cover rdfs:range. --------- Co-authored-by: Tvedt <bard.tvedt@akersolutions.com>
☂️ Python Coverage
Overall Coverage
New Files
Modified Files
|
doctrino
approved these changes
Jul 24, 2024
|
|
||
| Args: | ||
| filepath: Path to OWL ontology | ||
| filepath: Path to RDF file containing the SHACL Shapes |
There was a problem hiding this comment.
Should this take in filepath? It looks like you immediately start up a graph. So suggest that the init takes a Graph, or a NeatStore, and then have a factory method for this.
| "Properties": parse_owl_properties(graph), | ||
| "Metadata": parse_imf_metadata(), | ||
| "Classes": parse_imf_to_classes(graph), | ||
| "Properties": parse_imf_to_properties(graph), | ||
| } | ||
|
|
||
| components = make_components_compliant(components) |
There was a problem hiding this comment.
Below there is no catching of errors if the InformationRules failes
| for class_, class_grouped_df in class_grouped_dfs: | ||
| property_grouped_dfs = class_grouped_df.groupby("Property") | ||
| for property_, property_grouped_df in property_grouped_dfs: | ||
| clean_list += [ |
There was a problem hiding this comment.
Should there be warnings here if there are multiple values for any of the properties or is that not possible?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@bhtvedt made this PR:
A new step for importing rules has been added. The step converts Information Modelling Framework (IMF) types, given as SHACL shapes, into rules.
The new importer follows the compliance rules set by the OWL Importer, but most of the logic are, in this case, included the SPARQL queries. However, the validation checks are kept to ensure conformance.
The IMF identifiers are given as UUIDs, but CDF does not allow identifiers starting with a number. All the relevant identifiers are therefore prefixed with "IMF_"
IMF - attributes are properties that are described with several triples. An attribute contains relations to reference data describing the meaning of the attribute, as well as potential qualifiers and units of measure. To ensure that this information is included the attributes are created as both a class and property. This punning is required to ensure that both the usage of the attribute relative to an IMF block or terminal and the relationship to relevant reference data is captured.
In cases where a sh:property points to a sh:class or a sh:qualifiedValueShape the corresponding value is set as the expected value type of the property.
The logic should also cover rdfs:range.