Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Neat 347 extend depth transformer with typing #538

Merged
merged 8 commits into from
Jul 10, 2024

Conversation

nikokaoja
Copy link
Collaborator

[0.85.10] - 10-07-24

Added

  • Depth-based typing in AddAssetDepth transformer
  • Graph summary repr

Comment on lines 43 to 44
summary = dict(zip(store.summary.iloc[:, 0], store.summary.iloc[:, 1], strict=False))

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also added store.queries.list_types() that you can use.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool! I will move summary query there

Copy link
Collaborator

@doctrino doctrino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work

Copy link

github-actions bot commented Jul 10, 2024

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
22515 15724 70% 60% 🟢

New Files

No new covered files...

Modified Files

File Coverage Status
cognite/neat/_version.py 100% 🟢
cognite/neat/graph/queries/_base.py 69% 🟢
cognite/neat/graph/stores/_base.py 67% 🟢
cognite/neat/graph/transformers/_classic_cdf.py 99% 🟢
TOTAL 84% 🟢

updated for commit: eda2c24 by action🐍

@nikokaoja nikokaoja merged commit 9b6d846 into main Jul 10, 2024
7 checks passed
@nikokaoja nikokaoja deleted the NEAT-347-Extend-depth-transformer-with-typing branch July 10, 2024 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants