Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sol 866: Add permissions section to build job #525

Merged
merged 10 commits into from
Jun 28, 2024
Merged

Sol 866: Add permissions section to build job #525

merged 10 commits into from
Jun 28, 2024

Conversation

paramids
Copy link
Contributor

No description provided.

Copy link

github-actions bot commented Jun 28, 2024

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
22397 15641 70% 60% 🟢

New Files

No new covered files...

Modified Files

No covered modified files...

updated for commit: beb1521 by action🐍

@@ -11,6 +11,10 @@ jobs:
build-and-publish:
runs-on: ubuntu-latest
environment: CD

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

federation may requite environment to be called main

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You may need to create new action that build image independently into our internal registries that has main as an environment

Copy link

@pavelzubarev pavelzubarev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with comments.

- name: Install Poetry
uses: snok/install-poetry@v1
with:
version: 1.3.1

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

update that to the latest, if possible

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated to latest release version 1.3.4

@paramids paramids merged commit 69a2c9b into main Jun 28, 2024
7 checks passed
@paramids paramids deleted the SOL-866 branch June 28, 2024 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants