Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Creating dedicated entity types and new rules #510

Merged
merged 17 commits into from
Jun 25, 2024
Merged

Creating dedicated entity types and new rules #510

merged 17 commits into from
Jun 25, 2024

Conversation

nikokaoja
Copy link
Collaborator

@nikokaoja nikokaoja commented Jun 24, 2024 •
edited
Loading

  • added new entities AssetEntity and RelationshipsEntity
  • added new rules type AssetRules
  • added tests

@nikokaoja nikokaoja changed the title Creating dedicated entity types Creating dedicated entity types and new rules Jun 24, 2024
@nikokaoja nikokaoja marked this pull request as ready for review June 24, 2024 14:19
@nikokaoja nikokaoja requested a review from a team as a code owner June 24, 2024 14:19
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 25, 2024 •
edited
Loading

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
22003 15506 70% 60% 🟢

New Files

File Coverage Status
cognite/neat/rules/models/asset/init.py 100% 🟢
cognite/neat/rules/models/asset/_converter.py 0% 🟢
cognite/neat/rules/models/asset/_rules.py 65% 🟢
cognite/neat/rules/models/asset/_rules_input.py 63% 🟢
cognite/neat/rules/models/asset/_serializer.py 0% 🟢
cognite/neat/rules/models/asset/_validation.py 100% 🟢
TOTAL 55% 🟢

Modified Files

File Coverage Status
cognite/neat/_version.py 100% 🟢
cognite/neat/rules/_shared.py 100% 🟢
cognite/neat/rules/importers/_spreadsheet2rules.py 76% 🟢
cognite/neat/rules/models/init.py 100% 🟢
cognite/neat/rules/models/_base.py 69% 🟢
cognite/neat/rules/models/entities.py 87% 🟢
cognite/neat/workflows/steps/data_contracts.py 80% 🟢
TOTAL 87% 🟢

updated for commit: e1d3368 by action🐍

@nikokaoja @doctrino
Update tests/tests_unit/rules/test_models/test_asset_rules.py
4feb052 
Co-authored-by: Anders Albert <60234212+doctrino@users.noreply.github.com>
@nikokaoja @doctrino
Update tests/tests_unit/rules/test_models/test_asset_rules.py
1b6d427 
Co-authored-by: Anders Albert <60234212+doctrino@users.noreply.github.com>
@nikokaoja @doctrino
Update tests/tests_unit/rules/test_models/test_asset_rules.py
27c2f90 
Co-authored-by: Anders Albert <60234212+doctrino@users.noreply.github.com>
@nikokaoja nikokaoja merged commit 9b3b2b9 into main Jun 25, 2024
7 checks passed
@nikokaoja nikokaoja deleted the NEAT-96-AssetLoader branch June 25, 2024 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@doctrino doctrino doctrino approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nikokaoja @doctrino