[prep NEAT-236] Refactor DMS schema single model #449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified Files
|
nikokaoja
approved these changes
May 13, 2024
| @@ -179,21 +180,12 @@ def to_rules( | |||
|
|
|||
| def _create_rule_components( | |||
| self, | |||
| data_model: dm.DataModelApply, | |||
| schema: DMSSchema, | |||
There was a problem hiding this comment.
would not schema have data model ? why it is necessary to additionally data_model as arg?
There was a problem hiding this comment.
In case it is missing, the error has to be raised/not raised on the error above.
| @@ -73,7 +73,7 @@ def to_schema(self) -> DMSSchema: | |||
|
|
|||
| output = DMSSchema( | |||
| spaces=spaces, | |||
| data_models=dm.DataModelApplyList([data_model]), | |||
| data_model=data_model, | |||
There was a problem hiding this comment.
this if not mistaken reverts back to the original idea of only having single data model
There was a problem hiding this comment.
This version of the schema have always had multiple, but could have been in the legacy.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.