Neat 239 a has data filter can reference at most 10 views and or containers #445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikokaoja
commented
May 10, 2024
nikokaoja
commented
May 10, 2024
doctrino
reviewed
May 10, 2024
There was a problem hiding this comment.
Today, neat is never using a HasData filter on views, so I don't think we should introduce a Warning on too many views in a filter.
Furthermore, I would just raise the warning in the place were the filter is created. Then it is simpler, creating a PR to demonstrate. This seems more complex than necessary.
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified Files
|
doctrino
approved these changes
May 10, 2024
Comment on lines
+81
to
+87
| for view_id in view_inheritance: | ||
| if implemented_view := indexed_views.get(view_id): | ||
| inherited_referenced_containers |= implemented_view.referenced_containers() | ||
| else: | ||
| raise IncompleteSchemaError(missing_component=view_id).as_exception() | ||
|
|
||
| return directly_referenced_containers | inherited_referenced_containers |
There was a problem hiding this comment.
Thanks this helped, I struggled with the last one.
Comment on lines
+67
to
+70
| indexed_views = { | ||
| **{view.as_id(): view for view in self.views}, | ||
| **({view.as_id(): view for view in self.reference.views} if self.reference else {}), | ||
| } |
There was a problem hiding this comment.
Suggest adding this as a cached_property as it is independent of the method input.
There was a problem hiding this comment.
Nevermind, that will cause issues if more views are added later.
nikokaoja
deleted the
NEAT-239-A-hasData-filter-can-reference-at-most-10-views-and-or-containers
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[0.76.3] - 10-05-24
Added