Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NEAT-222] DMS (and all other rules) dump order 🖶 #433

Merged
merged 77 commits into from
May 6, 2024
Merged

Conversation

doctrino
Copy link
Collaborator

@doctrino doctrino commented May 5, 2024

Instead of writing any fancy logic in the individual exporters (for example ExcelExporter).

I moved the properties class_, name and description from the base class SheetEntity to each derived class. This is a little bit of repeated properties, but it makes controlling the order that the fields are dumped much much easier. This is also more robust, as the current implementation dependend on class always being the first property.

Copy link

github-actions bot commented May 5, 2024

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
19669 13299 68% 60% 🟢

New Files

No new covered files...

Modified Files

File Coverage Status
cognite/neat/rules/exporters/_rules2excel.py 83% 🟢
cognite/neat/rules/models/rules/_base.py 68% 🟢
cognite/neat/rules/models/rules/_dms_architect_rules.py 93% 🟢
cognite/neat/rules/models/rules/_domain_rules.py 98% 🟢
cognite/neat/rules/models/rules/_information_rules.py 90% 🟢
TOTAL 86% 🟢

updated for commit: 8add6d8 by action🐍

Copy link
Collaborator

@nikokaoja nikokaoja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will remove so much issues from end users

@@ -201,10 +204,10 @@ class DMSProperty(SheetEntity):
reference: URLEntity | ReferenceEntity | None = Field(default=None, alias="Reference", union_mode="left_to_right")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am tempted to move reference after constraint

Base automatically changed from upgrade-dms-importer to main May 6, 2024 13:04
@doctrino doctrino merged commit 02361ca into main May 6, 2024
7 checks passed
@doctrino doctrino deleted the dms-dump-order branch May 6, 2024 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants