-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NEAT-222] DMS (and all other rules) dump order 🖶 #433
Conversation
# Conflicts: # docs/CHANGELOG.md
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified Files
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will remove so much issues from end users
@@ -201,10 +204,10 @@ class DMSProperty(SheetEntity): | |||
reference: URLEntity | ReferenceEntity | None = Field(default=None, alias="Reference", union_mode="left_to_right") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am tempted to move reference
after constraint
Instead of writing any fancy logic in the individual exporters (for example
ExcelExporter
).I moved the properties
class_
,name
anddescription
from the base classSheetEntity
to each derived class. This is a little bit of repeated properties, but it makes controlling the order that the fields are dumped much much easier. This is also more robust, as the current implementation dependend onclass
always being the first property.