feat: add name to mt-class #994
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hamdielhamdi-cognite
force-pushed
the
add-name-to-mt-class
branch
from
ec17ecd
to
49733c7
Compare
hamdielhamdi-cognite
requested review from
BugGambit and
andersfylling
as code owners
hamdielhamdi-cognite
force-pushed
the
add-name-to-mt-class
branch
from
49733c7
to
819301d
Compare
hamdielhamdi-cognite
force-pushed
the
add-name-to-mt-class
branch
from
819301d
to
d5824b6
Compare
packages/alpha/src/types.ts
Outdated
| @@ -49,6 +50,7 @@ export interface MonitoringTaskCreate { | |||
| export interface MonitoringTask { | |||
| id: CogniteInternalId; | |||
| externalId?: CogniteExternalId; | |||
| name: String; | |||
There was a problem hiding this comment.
prefer string, not String
hamdielhamdi-cognite
force-pushed
the
add-name-to-mt-class
branch
from
7bd91fb
to
c9554dd
Compare
andersfylling
approved these changes
Mar 1, 2023
|
@hamdielhamdi-cognite you can use the labels auto-merge and auto-update to keep your PR in sync. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reflect the
monitoring- task-apichanges in the js-sdk, in the monitoring task api we added a new fieldname.