fix: ensure response ordering matches request when chunking a request #893
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #893 +/- ##
==========================================
- Coverage 84.06% 79.54% -4.53%
==========================================
Files 70 105 +35
Lines 1952 3329 +1377
Branches 249 492 +243
==========================================
+ Hits 1641 2648 +1007
- Misses 301 659 +358
- Partials 10 22 +12
|
BugGambit
commented
Sep 23, 2022
| @@ -129,15 +129,16 @@ describe('Events integration test', () => { | |||
| test('descending', async () => { | |||
| await client.events.list({ sort: { endTime: SortOrder.DESC } }); | |||
| }); | |||
| test('multiple props not supported', async () => { | |||
| test('multiple props supported', async () => { | |||
There was a problem hiding this comment.
The events API added support for multiple fields. So the test is not valid anymore.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See this Slack thread for context.
We had a bug when performing a request to the API and the SDK decides to chunk the request into smaller requests. The problem is that we were not guaranteed that the response order matched the input order.