Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(release): undo major version release without major version bump #697

Merged
merged 1 commit into from
Oct 12, 2021

Conversation

vegardok
Copy link
Contributor

Revert "feat(core): move authentication out of CogniteClient (#687)"

This reverts commit 879ed31.

Revert "feat(core): move authentication out of CogniteClient (#687)"

This reverts commit 879ed31.
@codecov
Copy link

codecov bot commented Oct 12, 2021

Codecov Report

Merging #697 (9451565) into master (de3557f) will increase coverage by 0.86%.
The diff coverage is 80.62%.

@@            Coverage Diff             @@
##           master     #697      +/-   ##
==========================================
+ Coverage   84.06%   84.92%   +0.86%     
==========================================
  Files          70       86      +16     
  Lines        1952     2893     +941     
  Branches      249      447     +198     
==========================================
+ Hits         1641     2457     +816     
- Misses        301      436     +135     
+ Partials       10        0      -10     
Impacted Files Coverage Δ
packages/beta/src/cogniteClient.ts 100.00% <ø> (ø)
packages/stable/src/__tests__/testUtils.ts 100.00% <ø> (ø)
...stable/src/api/entityMatching/entityMatchingApi.ts 37.14% <ø> (ø)
packages/stable/src/retryValidator.ts 100.00% <ø> (ø)
packages/stable/src/api/3d/assetMappings3DApi.ts 79.16% <16.66%> (-20.84%) ⬇️
packages/stable/src/api/3d/nodes3DApi.ts 81.81% <20.00%> (-18.19%) ⬇️
packages/stable/src/api/projects/projectsApi.ts 78.94% <20.00%> (-21.06%) ⬇️
packages/core/src/baseResourceApi.ts 34.00% <25.00%> (-5.07%) ⬇️
packages/stable/src/api/3d/revisions3DApi.ts 95.65% <33.33%> (-4.35%) ⬇️
packages/beta/src/__tests__/testUtils.ts 76.92% <40.00%> (-23.08%) ⬇️
... and 82 more

@vegardok vegardok merged commit 72e1ecb into master Oct 12, 2021
@vegardok vegardok deleted the fix-v5 branch October 12, 2021 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants