chore: upgrade to typescript 5 #1135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: es6 module (vs es5) and typescript 3 -> 5
BugGambit
commented
Aug 22, 2024
| @@ -85,7 +85,7 @@ jobs: | |||
| env: | |||
| GH_TOKEN: ${{ secrets.GH_LERNA_TOKEN }} # Temporary fix to make lerna able to push the new versions commit to master | |||
| GITHUB_TOKEN: ${{ secrets.GH_LERNA_TOKEN }} # Temporary fix to make lerna able to push the new versions commit to master | |||
| run: yarn lerna version --conventional-commits --create-release github --no-private --yes | |||
| run: yarn lerna version --conventional-commits --conventional-prerelease --preid rc --create-release github --no-private --yes | |||
There was a problem hiding this comment.
In this major release, we start with releasing release candidates (rc)
BugGambit
commented
Aug 22, 2024
Comment on lines
+13
to
+34
| _.cloneDeepWith(jsDoc, (value, key, object) => { | ||
| if (key !== 'summary') { | ||
| return; | ||
| } | ||
| if (!Array.isArray(value) || value.length === 0) { | ||
| return; | ||
| } | ||
| if (value[0].kind !== 'text') { | ||
| return; | ||
| } | ||
| const docRegEx = | ||
| /https:\/\/(doc\.cognitedata\.com|docs\.cognite\.com|developer\.cognite\.com)\/api.*operation\/([a-zA-Z0-9]+)/g; | ||
| let matches; | ||
| while (true) { | ||
| matches = docRegEx.exec(value); | ||
| if (!matches) { | ||
| break; | ||
| const matches = value[0].text.matchAll(docRegEx); | ||
| for (const match of matches) { | ||
| const operationId = match[2]; | ||
| if (value.length !== 2) { | ||
| throw new Error('Unexpected length of summary'); | ||
| } | ||
| if (value[1].kind !== 'code') { | ||
| throw new Error(`Expected code snippet, but got ${value[1].kind}`); | ||
| } | ||
| const operationId = matches[2]; | ||
| const rawCode = object.text; | ||
| const rawCode = value[1].text; |
There was a problem hiding this comment.
The typedoc output format has changed in the recent version
anjalirai2626
approved these changes
Aug 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR upgrades to Typescript 5 from 3, and resolve breaking changes.
We also replace Rollup with Vite and change the SDKs from es5 compatibility to become es6 modules.
We are not merging this into
masteras we would like to bulk up multiple breaking changes before the final release. We, therefore, use the target branchrelease-v10(protected), and this PR is against that branch.We have configured this branch to publish release candidates to npm.