Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(beta): skip flaky alerts api test temporarily #1133

Merged
merged 3 commits into from
Aug 23, 2024

Conversation

saagar-cognite
Copy link
Contributor

@saagar-cognite saagar-cognite commented Aug 21, 2024

https://cognitedata.slack.com/archives/C05A4PX656F/p1724010276336469

After some discussion on the above thread, we have decided to skip this test until we find a fix.

Reason:
The cursor pagination test is creating more than 1000 alerts which is currently very slow.
Which could be a probably reason for 504 error.

We will later either try to make smaller page size and create less alerts or do a cleanup before all tests are run to clear all alerts which could help with sorting in database.

@saagar-cognite saagar-cognite requested a review from a team as a code owner August 21, 2024 14:12
BugGambit
BugGambit previously approved these changes Aug 21, 2024
@BugGambit BugGambit self-requested a review August 21, 2024 18:37
@BugGambit BugGambit dismissed their stale review August 21, 2024 18:37

wrong title

@BugGambit
Copy link
Contributor

Please update PR title to be test: ...

@saagar-cognite saagar-cognite changed the title fix(beta): skip flaky alerts api test temporarily test(beta): skip flaky alerts api test temporarily Aug 21, 2024
@saagar-cognite saagar-cognite enabled auto-merge (squash) August 22, 2024 11:31
@saagar-cognite saagar-cognite merged commit bb7f9cb into master Aug 23, 2024
9 checks passed
@saagar-cognite saagar-cognite deleted the fix/beta-alerts-test-skip branch August 23, 2024 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants