fix: simulation run data api path (#1102)

* fix: fix run data path * fix: rename validationEndTime to runTime * fix: fix some tests
cognitedata · May 2, 2024 · 24ced6f · 24ced6f
1 parent 0d1246f
commit 24ced6f
Show file tree

Hide file tree

Showing 4 changed files with 11 additions and 9 deletions.
diff --git a/packages/alpha/src/__tests__/api/simulationRunsApi.int.spec.ts b/packages/alpha/src/__tests__/api/simulationRunsApi.int.spec.ts
@@ -15,9 +15,9 @@ describeIf('simulator integrations api', () => {
   test('run a simulation', async () => {
     const res = await client.simulators.runSimulation([
       {
-        routineExternalId: 'ShowerMixerIntegrationTestConstInputs',
+        routineExternalId: 'ShowerMixerWithExtendedIO',
         runType: 'external',
-        validationEndTime: new Date(ts),
+        runTime: new Date(ts),
         queue: true,
       },
     ]);
@@ -30,11 +30,13 @@ describeIf('simulator integrations api', () => {
     const item = res[0];
 
     expect(item.simulatorName).toBe('DWSIM');
-    expect(item.modelName).toBe('ShowerMixerIntegrationTest');
-    expect(item.routineName).toBe('ShowerMixerIntegrationTest');
+    expect(item.modelName).toBe('Shower Mixer');
+    expect(item.routineName).toBe(
+      'Shower Mixer With Extended Inputs / Outputs'
+    );
     expect(item.status).toBe('ready');
     expect(item.runType).toBe('external');
-    expect(item.validationEndTime?.valueOf()).toBe(ts);
+    expect(item.runTime?.valueOf()).toBe(ts);
     expect(item.createdTime.valueOf()).toBeGreaterThanOrEqual(ts);
     expect(item.lastUpdatedTime.valueOf()).toBeGreaterThanOrEqual(ts);
   });

diff --git a/packages/alpha/src/api/simulators/simulationRunDataApi.ts b/packages/alpha/src/api/simulators/simulationRunDataApi.ts
@@ -9,7 +9,7 @@ export class SimulationRunDataAPI extends BaseResourceAPI<SimulationRunData> {
   }
 
   public retrieve = async (ids: SimulationRunId[]) => {
-    const path = this.url('simulators/runs/data/list');
+    const path = this.url('list');
 
     return this.retrieveEndpoint(ids, {}, path);
   };

diff --git a/packages/alpha/src/api/simulators/simulationRunsApi.ts b/packages/alpha/src/api/simulators/simulationRunsApi.ts
@@ -19,7 +19,7 @@ export class SimulationRunsAPI extends BaseResourceAPI<SimulationRun> {
   protected getDateProps() {
     return this.pickDateProps(
       ['items'],
-      ['createdTime', 'lastUpdatedTime', 'validationEndTime', 'simulationTime']
+      ['createdTime', 'lastUpdatedTime', 'runTime', 'simulationTime']
     );
   }
 

diff --git a/packages/alpha/src/types.ts b/packages/alpha/src/types.ts
@@ -193,7 +193,7 @@ export const SimulationRunType = {
 export interface SimulationRunCreate {
   routineExternalId: CogniteExternalId;
   runType?: SimulationRunType;
-  validationEndTime?: Date;
+  runTime?: Date;
   queue?: boolean;
 }
 
@@ -218,7 +218,7 @@ export interface SimulationRun {
   routineExternalId?: CogniteExternalId;
   routineRevisionExternalId?: CogniteExternalId;
   status: SimulationRunStatus;
-  validationEndTime?: Date;
+  runTime?: Date;
   simulationTime?: Date;
   statusMessage?: string;
   dataSetId?: CogniteInternalId;