Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep timestamps off stack (Fix #41) #42

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Kacarott
Copy link
Contributor

Removes timestamps from the stack for it#{ and describe#{ blocks, keeping them instead in the retain stack, inaccessible to user code. Since timestamps are an implementation detail and can cause unexpected behaviour, I believe it is an important change.

Note that this was tested against the existing 0.98 version, it is possible (though I doubt it) that it may require modifications for 0.99.

Edits and feedback are of course welcome.

@Kacarott
Copy link
Contributor Author

It looks like this patch still works for 0.99.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant