fix: Fixed toolbar overlapping dynamic islands on iOS #3763
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The toolbar will now set the status bar as a safe area, if it creates the statusbar spacer (which it does on iOS). Otherwise the toolbar itself will be a safe area. Fixes #3761
|
I see there are some test failures. That is due to the fact that this is pushing the position of some components down properly now to accommodate safe areas now. I need to adjust these tests. |
Previously the padding units or margin units to top/left/bottom/right on a proxy style, were not being applied to the underlying styles. Now they are.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The toolbar will now set the status bar as a safe area, if it creates the statusbar spacer (which it does on iOS). Otherwise the toolbar itself will be a safe area. Fixes #3761
Screenshot with this fix employed.
Before this fix:
After this fix: