Upgrade Guice to 6 - Add support to run test with jakarta @Inject annotations #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olamy
approved these changes
May 27, 2023
There was a problem hiding this comment.
Good idea to test that. sounds promising to see only an upgrade of Guice is needed and nothing in Sisu?
It would be good to see if jakarta.inject will be supported so easily in the Maven eco system
nit maybe the PR title should include the guice upgrade as well.
slachiewicz
force-pushed
the
addJakartaSupport
branch
from
91383e5
to
ea9999f
Compare
slachiewicz
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.