Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

How Maple Uses AI #1617

Merged
merged 15 commits into from
Sep 17, 2024
Merged

How Maple Uses AI #1617

merged 15 commits into from
Sep 17, 2024

Conversation

mertbagt
Copy link
Collaborator

@mertbagt mertbagt commented Sep 11, 2024 •
edited
Loading

Summary

#1605

  • Add a new sub page "How MAPLE Uses AI" under the About section
  • Add navigational links to the Desktop Navbar, Mobile Navbar and Footer sections
  • filled out translation support as instances that needed it were encountered

Checklist

  • On the frontend, I've made my strings translate-able.
  • If I've added shared components, I've added a storybook story.
  • I've made pages responsive and look good on mobile.

Screenshots

image

image

image

image

Known issues

none at this time

Steps to test/reproduce

  1. On Desktop, from the header navbar -> About -> How MAPLE Uses AI
  2. On Mobile, from the header navbar -> About -> How MAPLE Uses AI
  3. from the footer -> About -> How MAPLE Uses AI
  4. check that How MAPLE Uses AI page looks good

@vercel Vercel
Copy link

vercel bot commented Sep 11, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
maple-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 11, 2024 7:03pm

@mertbagt mertbagt marked this pull request as draft September 11, 2024 00:35
@mertbagt mertbagt marked this pull request as ready for review September 11, 2024 19:07
Mephistic
Mephistic approved these changes Sep 17, 2024
View reviewed changes
Copy link
Collaborator

@Mephistic Mephistic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks for extracting text for the recent copy updates!

One note - it might be a good idea to put the LLM changes behind a new feature flag (enabled in local/dev, disabled in prod) until we're ready to go live to avoid confusion.

@Mephistic Mephistic merged commit c126632 into codeforboston:main Sep 17, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mephistic Mephistic Mephistic approved these changes

@sashamaryl sashamaryl Awaiting requested review from sashamaryl sashamaryl is a code owner

@nesanders nesanders Awaiting requested review from nesanders nesanders is a code owner

@mvictor55 mvictor55 Awaiting requested review from mvictor55 mvictor55 is a code owner

@timblais timblais Awaiting requested review from timblais timblais is a code owner

@alexjball alexjball Awaiting requested review from alexjball alexjball is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mertbagt @Mephistic