FaqCard rework #1420
Merged
FaqCard rework #1420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mertbagt
requested review from
sashamaryl,
nesanders,
mvictor55,
timblais and
alexjball
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
This was referenced Feb 20, 2024
sashamaryl
approved these changes
Mar 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
closes #1466
Refactored components to integrate Bootstrap and styled-components (with a preference for Bootstrap as much as possible) while removing CSS modules.
Added Storybook components
Checklist
Screenshots
pages should not look significantly different. Some minor changes like font-sizes are no longer specified and will temporarily look different but there is a separate issue to standardize things like font-sizes across the app. When implemented those standardizations will establish the default font-sizes for this page.
Known issues
Elected not to use the standardized Maple Card. Can bring the faq cards in line with Maple Card if that design change is wanted; otherwise it is expected the overall previous design work will stand.