Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hide rescind testimony button #1235

Merged
merged 1 commit into from
Jul 19, 2023
Merged

Conversation

mertbagt
Copy link
Collaborator

@mertbagt mertbagt commented Jul 19, 2023

Summary

#1234

Remove the "Request to Rescind" text.

Prior to this PR, it currently shows up whenever you view your own testimony, which is 1) when you view a bill you've added testimony to, 2) when you view your own profile, and 3) when you click 'edit profile' and view the list of your testimonies.

image

Checklist

  • On the frontend, I've made my strings translate-able.
  • If I've added shared components, I've added a storybook story.
  • I've made pages responsive and look good on mobile.

Screenshots

On Bill Page
image

On View Profile
image

On Edit Profile
image

Known issues

No known issues

Steps to test/reproduce

For each feature or bug fix, create a step by step list for how a reviewer can test it out. E.g.:

  • for each step, make sure "Request to rescind" option is not visible
  1. Navigate to a bill that has one's own testimony
  2. Navigate to View Profile
  3. Naviate to Edit Profile -> Testimonies tab

@vercel
Copy link

vercel bot commented Jul 19, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
maple-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 19, 2023 1:36am

@vercel
Copy link

vercel bot commented Jul 19, 2023

@mertbagt is attempting to deploy a commit to the Maple Testimony Team on Vercel.

A member of the Team first needs to authorize it.

@mvictor55
Copy link
Collaborator

gracias!

Copy link
Collaborator

@sashamaryl sashamaryl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mertbagt mertbagt merged commit 293cd73 into codeforboston:main Jul 19, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants