Skip to content
This repository has been archived by the owner on Feb 28, 2022. It is now read-only.

Scroll cards #394

Open
wants to merge 10 commits into
base: development
Choose a base branch
from
Open

Conversation

skgigliotti
Copy link
Collaborator

Description

  • The search and sort bar always stays at the top of the card pane. The div CardList is now enclosed in another div called CardPane. CarList has the css property overflow: auto.
  • The category List also stays fixed. The Form div for the categories is now enclosed in another div called CategoryPane. CategoryPane has the property overflow: auto.
  • Mobile view for the admin page is split between the category list and the card pane to also solve the problem of keeping the search and sort bar visible.

Web View (bar now sticks at the top as cards scroll)
image

Mobile View
image

Fixes #286

Motivation and Context

The search and sort bar is always visible as the users scroll through cards in both web and mobile view.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

@RajChaudhry
Copy link
Collaborator

Thanks Sophia! I am not an expert at heavy CSS changes, so I don't feel super comfortable approving the PR by myself. If @acharliekelly and someone else can look at it, that'd be great. However, the functionality is all still here for sure. Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Top bar and Filtering to be made static
2 participants