[WIP] PR to fix the react testing library console warnings in the PR for issue-101 #111
Conversation
|
Personal notes: facebook/react#14769 is relevant |
lpatmo
force-pushed
the
issue-101-fix-rtl-tests
branch
from
667871f
to
d842ed6
Compare
src/components/Auth/AuthForm.spec.js
Outdated
| <SignUpForm /> | ||
| </BrowserRouter> | ||
| ); | ||
| fit('Register a new user on the signup form', async () => { |
There was a problem hiding this comment.
Yeah, that was so I could test a single test at a time :) I pushed up a commit... one sec!
There was a problem hiding this comment.
I applied bf9c00b based on @gauravchl's suggestion in 89b5156, but the interesting thing here is that if I run each test using fit individually, the tests pass without those warnings.
But if I run npm run test with that commit in place, I still see:
Not sure if there is something I'm obvious I missed, but tldr I'm very surprised to still see that error if I don't run each test individually...
There was a problem hiding this comment.
I recorded a quick screenrecording about the problem: https://gitduck.com/watch/5ea551ce1f9488f393e05e1a
|
Closing this out since Gaurav fixed these warnings in #105! |
Creating this PR so there's a git diff to easily refer back to.