Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Short the following require messages #6

Closed
code423n4 opened this issue Jan 27, 2022 · 1 comment
Closed

Short the following require messages #6

code423n4 opened this issue Jan 27, 2022 · 1 comment
Labels
bug Something isn't working duplicate This issue or pull request already exists G (Gas Optimization) resolved Finding has been patched by sponsor (sponsor pls link to PR containing fix) sponsor confirmed Sponsor agrees this is a problem and intends to fix it (OK to use w/ "disagree with severity")

Comments

@code423n4
Copy link
Contributor

Handle

robee

Vulnerability details

The following require messages are of length more than 32 and we think are short enough to short
them into exactly 32 characters such that it will be placed in one slot of memory and the require
function will cost less gas.
The list:

    Solidity file: LimboDAO.sol, In line 272, Require message length to shorten: 35, The message: LimboDAO: voting on proposal closed
    Solidity file: FlashGovernanceArbiter.sol, In line 143, Require message length to shorten: 40, The message: Limbo: Flashgovernance decision pending.
    Solidity file: Flan.sol, In line 96, Require message length to shorten: 37, The message: ERC20: transfer from the zero address
    Solidity file: Flan.sol, In line 103, Require message length to shorten: 38, The message: ERC20: transfer amount exceeds balance
    Solidity file: Flan.sol, In line 97, Require message length to shorten: 35, The message: ERC20: transfer to the zero address
    Solidity file: UniswapHelper.sol, In line 94, Require message length to shorten: 36, The message: Uniswap factory hardcoded on mainnet
    Solidity file: FlanBackstop.sol, In line 102, Require message length to shorten: 38, The message: BACKSTOP: potential price manipulation
@code423n4 code423n4 added bug Something isn't working G (Gas Optimization) labels Jan 27, 2022
code423n4 added a commit that referenced this issue Jan 27, 2022
@gititGoro gititGoro added the sponsor confirmed Sponsor agrees this is a problem and intends to fix it (OK to use w/ "disagree with severity") label Jan 31, 2022
@gititGoro gititGoro added the unresolved indicate confirmed issues that haven't been resolved with a PR label Feb 12, 2022
@jack-the-pug
Copy link
Collaborator

Dup #185

@CloudEllie CloudEllie added the duplicate This issue or pull request already exists label Feb 28, 2022
@gititGoro gititGoro added resolved Finding has been patched by sponsor (sponsor pls link to PR containing fix) and removed unresolved indicate confirmed issues that haven't been resolved with a PR labels Jul 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working duplicate This issue or pull request already exists G (Gas Optimization) resolved Finding has been patched by sponsor (sponsor pls link to PR containing fix) sponsor confirmed Sponsor agrees this is a problem and intends to fix it (OK to use w/ "disagree with severity")
Projects
None yet
Development

No branches or pull requests

4 participants