Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FilesDownloader: Downloaded file is corrupted if there is a duplicate entry #120

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

soccerob
Copy link

If the same file path is added twice to the same FilesDownloader instance, the first one will begin to download and add data to the .tmp file, then the second will begin to download with the same .tmp filename, and corrupt the first one. This was fixed by stripping out duplicates, which are obviously not needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant